lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 7 Jul 2014 22:00:05 +0200 From: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> To: Lee Jones <lee.jones@...aro.org> Cc: Jingoo Han <jg1.han@...sung.com>, Bryan Wu <cooloney@...il.com>, Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>, Tomi Valkeinen <tomi.valkeinen@...com>, Linux Fbdev development list <linux-fbdev@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] video: backlight: jornada720_lcd.c: Cleaning up variable that is never used 2014-07-07 12:46 GMT+02:00 Lee Jones <lee.jones@...aro.org>: >> Variable ar assigned a value that is never used. >> I have also removed all the code that thereby serves no purpose. >> >> This was found using a static code analysis program called cppcheck >> >> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> >> --- >> drivers/video/backlight/jornada720_lcd.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) > > Solve it the other way around. > > Add a check and return the value if an error is returned. Hi Ok, I take the opportunity to make a bigger change to clarify the similarities in function. Hope you like it, otherwise I can make the minor change instead. Kind regards Rickard Strandqvist -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists