linux-kernel - Re: [PATCH 1/1] drm/radeon: remove null test before kfree

Open Source and information security mailing list archives

Date:	Mon, 7 Jul 2014 16:42:53 -0400
From:	Alex Deucher <alexdeucher@...il.com>
To:	Fabian Frederick <fabf@...net.be>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Alex Deucher <alexander.deucher@....com>,
	Maling list - DRI developers 
	<dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH 1/1] drm/radeon: remove null test before kfree

On Fri, Jul 4, 2014 at 3:37 PM, Fabian Frederick <fabf@...net.be> wrote:
> Fix checkpatch warning:
> WARNING: kfree(NULL) is safe this check is probably not required
>
> Cc: Alex Deucher <alexander.deucher@....com>
> Cc: David Airlie <airlied@...ux.ie>
> Cc: dri-devel@...ts.freedesktop.org
> Signed-off-by: Fabian Frederick <fabf@...net.be>

Applied.  thanks!

Alex

> ---
>  drivers/gpu/drm/radeon/radeon_pm.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_pm.c b/drivers/gpu/drm/radeon/radeon_pm.c
> index e447e39..a06afee 100644
> --- a/drivers/gpu/drm/radeon/radeon_pm.c
> +++ b/drivers/gpu/drm/radeon/radeon_pm.c
> @@ -1400,9 +1400,7 @@ static void radeon_pm_fini_old(struct radeon_device *rdev)
>         }
>
>         radeon_hwmon_fini(rdev);
> -
> -       if (rdev->pm.power_state)
> -               kfree(rdev->pm.power_state);
> +       kfree(rdev->pm.power_state);
>  }
>
>  static void radeon_pm_fini_dpm(struct radeon_device *rdev)
> @@ -1421,9 +1419,7 @@ static void radeon_pm_fini_dpm(struct radeon_device *rdev)
>         radeon_dpm_fini(rdev);
>
>         radeon_hwmon_fini(rdev);
> -
> -       if (rdev->pm.power_state)
> -               kfree(rdev->pm.power_state);
> +       kfree(rdev->pm.power_state);
>  }
>
>  void radeon_pm_fini(struct radeon_device *rdev)
> --
> 1.9.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives