lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Sun, 6 Jul 2014 22:42:08 -0700
From:	Greg KH <greg@...ah.com>
To:	Julia Lawall <julia.lawall@...6.fr>
Cc:	Himangi Saraogi <himangi774@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] thunderbolt: Correct the size argument to devm_kzalloc

On Mon, Jul 07, 2014 at 06:32:04AM +0200, Julia Lawall wrote:
> 
> 
> On Sun, 6 Jul 2014, Greg KH wrote:
> 
> > On Sun, Jul 06, 2014 at 09:43:42PM +0530, Himangi Saraogi wrote:
> > > nhi->rx_rings does not have type as struct tb_ring *, as it is a
> > > double pointer so the elements of the array should have pointer type,
> > > not structure type.
> > > 
> > > The Coccinelle semantic patch that makes this change is as follows:
> > > 
> > > // <smpl>
> > > @disable sizeof_type_expr@
> > > type T;
> > > T **x;
> > > @@
> > > 
> > >   x =
> > >   <+...sizeof(
> > > - T
> > > + *x
> > >   )...+>
> > > // </smpl>
> > > 
> > > Signed-off-by: Himangi Saraogi <himangi774@...il.com>
> > > Acked-by: Julia Lawall <julia.lawall@...6.fr>
> > > ---
> > >  drivers/thunderbolt/nhi.c | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > Any reason you didn't cc: the developers in charge of this code so they
> > see it and can pick it up?  Otherwise it's just going to float around on
> > the mailing list, listless and sad.
> 
> They don't seem to be in the MAINTAINERS file.

Ah, good point.  Andreas, care to send me a patch adding yourself to the
MAINTAINERS file for drivers/thunderbolt/* so that you will get patches
like this?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists