linux-kernel - Re: [PATCH 1/1] dvb-frontends: remove unnecessary break after goto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140709041215.3e1083201f5a400c37b820b0@skynet.be>
Date:	Wed, 9 Jul 2014 04:12:15 +0200
From:	Fabian Frederick <fabf@...net.be>
To:	Antti Palosaari <crope@....fi>
Cc:	linux-kernel@...r.kernel.org,
	Mauro Carvalho Chehab <m.chehab@...sung.com>,
	linux-media@...r.kernel.org
Subject: Re: [PATCH 1/1] dvb-frontends: remove unnecessary break after goto

On Tue, 08 Jul 2014 21:35:58 +0300
Antti Palosaari <crope@....fi> wrote:

> Moikka Fabian!
> I have no reason to decline that patch (I will apply it) even it has 
> hardly meaning. But is there now some new tool which warns that kind of 
> issues?
Hello Antti,

	Thanks :) AFAIK there's still no automatic detection of those cases.

Regards,
Fabian
> 
> regards
> Atnti
> 
> 
> On 07/08/2014 08:23 PM, Fabian Frederick wrote:
> > Cc: Antti Palosaari <crope@....fi>
> > Cc: Mauro Carvalho Chehab <m.chehab@...sung.com>
> > Cc: linux-media@...r.kernel.org
> > Signed-off-by: Fabian Frederick <fabf@...net.be>
> > ---
> >   drivers/media/dvb-frontends/af9013.c | 1 -
> >   1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/media/dvb-frontends/af9013.c b/drivers/media/dvb-frontends/af9013.c
> > index fb504f1..ecf6388 100644
> > --- a/drivers/media/dvb-frontends/af9013.c
> > +++ b/drivers/media/dvb-frontends/af9013.c
> > @@ -470,7 +470,6 @@ static int af9013_statistics_snr_result(struct dvb_frontend *fe)
> >   		break;
> >   	default:
> >   		goto err;
> > -		break;
> >   	}
> >
> >   	for (i = 0; i < len; i++) {
> >
> 
> -- 
> http://palosaari.fi/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/