linux-kernel - RE: [PATCH] usb: dwc2: remove incomplete DMA support from gadget code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <A2CA0424C0A6F04399FB9E1CD98E0304844BCBFA@US01WEMBX2.internal.synopsys.com>
Date:	Tue, 8 Jul 2014 20:04:47 +0000
From:	Paul Zimmerman <Paul.Zimmerman@...opsys.com>
To:	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
	"Dinh Nguyen (dinguyen@...era.com)" <dinguyen@...era.com>
CC:	Felipe Balbi <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Ben Dooks <ben.dooks@...ethink.co.uk>,
	"Robert Baldyga" <r.baldyga@...sung.com>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] usb: dwc2: remove incomplete DMA support from gadget
 code

> From: Bartlomiej Zolnierkiewicz [mailto:b.zolnierkie@...sung.com]
> Sent: Tuesday, July 08, 2014 7:55 AM
> 
> The commit 5b7d70c6dbf2 ("USB: Gadget driver for Samsung HS/OtG
> block") which added this driver also introduced the inactive DMA
> support (due to hardware limitations of DMA buffers alignment).
> It has been a dead code for over 5 years and should be removed.
> 
> We don't keep the unused/untested features in the kernel.  Such
> code has a real maintainance cost (all other changes have to take
> dead code into account), i.e. https://lkml.org/lkml/2014/5/6/461.
> Also all the removed dead code is still accessible in the kernel
> git repository and can be easily brought back if/when needed.
> 
> There should be no functional changes caused by this patch.
> 
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
> Acked-by: Kyungmin Park <kyungmin.park@...sung.com>

Hmm. I'd rather not apply this for the time being. Dinh Nguyen is
working on a patch to combine the two dwc2 drivers into a dual-role
driver. I suspect his platform will be able to use DMA. Also, once that
is done, I plan to enable device-mode support for the Synopsys
development platform, which also supports DMA.

If none of this happens over the next couple of months, we can reconsider
applying this patch. After all, the code has been there for 5 years, a
couple more months won't hurt. Sound OK?

-- 
Paul

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/