linux-kernel - Re: [RFC 2/2] prctl: PR_SET_MM -- Introduce PR_SET_MM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140708143830.ea078ef01e1d7d31276edbcd@linux-foundation.org>
Date:	Tue, 8 Jul 2014 14:38:30 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Cyrill Gorcunov <gorcunov@...il.com>
Cc:	linux-kernel@...r.kernel.org, Kees Cook <keescook@...omium.org>,
	Tejun Heo <tj@...nel.org>, Andrew Vagin <avagin@...nvz.org>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Serge Hallyn <serge.hallyn@...onical.com>,
	Pavel Emelyanov <xemul@...allels.com>,
	Vasiliy Kulikov <segoon@...nwall.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	Michael Kerrisk <mtk.manpages@...il.com>
Subject: Re: [RFC 2/2] prctl: PR_SET_MM -- Introduce PR_SET_MM_MAP operation

On Tue, 8 Jul 2014 23:08:49 +0400 Cyrill Gorcunov <gorcunov@...il.com> wrote:

> Ping. Guys, any commens please?

Well, allowing a process to modify pretty deep internals like this is
always scary from a security point of view, and now we're removing
CAP_SYS_RESOURCE protections.  Yikes.  Convince me we aren't handing
out root here.

The changelog doesn't make it clear (to me) why this is actually being
done.  criu runs unprivileged?  What's the requirement here?

struct prctl_mm_map could do with a nice comment explaining its role in
the world.

I'm not seeing a coherent description of the proposed userspace
interface.  We'll eventually want to update the prctl manpage for this,
so how about laying out all the needed details now, at patch review
time so we can see what is proposed.

Why isn't the newly-added code under #ifdef CONFIG_CHECKPOINT_RESTORE?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/