linux-kernel - Re: [PATCH v2] Documentation: Rename hpfall.c => freefall.c, fixes for Dell

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <53BC758A.5060303@infradead.org>
Date:	Tue, 08 Jul 2014 15:49:46 -0700
From:	Randy Dunlap <rdunlap@...radead.org>
To:	Pali Rohár <pali.rohar@...il.com>
CC:	Matthew Garrett <matthew.garrett@...ula.com>,
	Pavel Machek <pavel@....cz>,
	Valdis Kletnieks <valdis.kletnieks@...edu>,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
	platform-driver-x86@...r.kernel.org,
	Sonal Santan <sonal.santan@...il.com>
Subject: Re: [PATCH v2] Documentation: Rename hpfall.c => freefall.c, fixes
 for Dell

On 07/07/2014 11:15 AM, Pali Rohár wrote:
> Hello Randy, sorry but now I do not have any free time...

a. It took me 7 minutes to split the patch into 2 patches as I requested.

b. In the future please do it like that.

c. Pavel asked me to go ahead and apply the patch. I will do that since
I have a few other patches to hpfall.c (freefall.c) that need to be applied.


> On Sunday 29 June 2014 04:12:17 Randy Dunlap wrote:
>> Hi,
>>
>> This should really be done as 2 separate patches:
>> One to move/rename the file and one to make the
>> changes/additions to it for DELL.
>>
>> Can you resend it as 2 patches like that, please?
>>
>> Thanks... and sorry for the delay.
>>
>> On 06/11/14 01:02, Pali Rohár wrote:
>>> Dell kernel driver dell-smo8800 provides same freefall
>>> interface as hp_accel so program hpfall.c works also on
>>> Dell laptops. So rename it to freefall.c.
>>>
>>> Dell driver does not provide hp::hddprotect led so make sure
>>> that freefall.c works also if hp::hddprotect does not exist
>>> in sysfs.
>>>
>>> Additionally write info to syslog.
>>>
>>> Signed-off-by: Pali Rohár <pali.rohar@...il.com>
>>> Cc: Sonal Santan <sonal.santan@...il.com>
>>> ---
>>> Changes since v1:
>>> * Fixed warnings: Missing a blank line after declarations
>>> ---
>>>
>>>  Documentation/laptops/00-INDEX   |    4 +-
>>>  Documentation/laptops/freefall.c |  177
>>>  ++++++++++++++++++++++++++++++++++++++
>>>  Documentation/laptops/hpfall.c   |  146
>>>  ------------------------------- 3 files changed, 179
>>>  insertions(+), 148 deletions(-) create mode 100644
>>>  Documentation/laptops/freefall.c delete mode 100644
>>>  Documentation/laptops/hpfall.c
> 


-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/