linux-kernel - Re: [RFC 2/3] gpio: move sysfs support to its own file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAVeFuKrvvmWGS0OaP+JBmozT70K9=0ntL7Zx+vZPBjr2H8aDg@mail.gmail.com>
Date:	Tue, 8 Jul 2014 17:31:01 +0900
From:	Alexandre Courbot <gnurou@...il.com>
To:	Linus Walleij <linus.walleij@...aro.org>
Cc:	Alexandre Courbot <acourbot@...dia.com>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [RFC 2/3] gpio: move sysfs support to its own file

On Tue, Jul 8, 2014 at 5:21 PM, Linus Walleij <linus.walleij@...aro.org> wrote:
> On Tue, Jul 1, 2014 at 7:45 AM, Alexandre Courbot <acourbot@...dia.com> wrote:
>
>> sysfs support is currently entangled within the core GPIO support, while
>> it should relly just be a (privileged) user of the integer GPIO API.
>> This patch is a first step towards making the gpiolib code more readable
>> by splitting it into logical parts.
>>
>> Move all sysfs support to their own source file, and share static
>> members of gpiolib that need to be in the private gpiolib.h file. In
>> the future we will want to put some of them back into gpiolib.c, but this
>> first patch let us at least identify them.
>>
>> Signed-off-by: Alexandre Courbot <acourbot@...dia.com>
>
> Patch applied. We really need to make refactorings like this
> so thanks a lot.

Excellent, glad you approve of this. I actually have some more coming
after that, since the current lack of organization stands in the way
of a proper multi-consumer GPIO implementation.

Thanks!
Alex.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/