linux-kernel - Re: [GIT PULL] SPEAr1310 PCIe patches rebased on 3.16-rc3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 8 Jul 2014 14:23:56 +0530
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	Mohit KUMAR DCG <Mohit.KUMAR@...com>
Cc:	"arm@...nel.org" <arm@...nel.org>,
	"Arnd Bergmann (arnd@...db.de)" <arnd@...db.de>,
	"'Bjorn Helgaas' (bhelgaas@...gle.com)" <bhelgaas@...gle.com>,
	"'Kishon Vijay Abraham I' (kishon@...com)" <kishon@...com>,
	Pratyush ANAND <pratyush.anand@...com>,
	spear-devel <spear-devel@...t.st.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
	Mark Nicholson <mark@...holnet.com>
Subject: Re: [GIT PULL] SPEAr1310 PCIe patches rebased on 3.16-rc3

Hi Mohit,

On Tue, Jul 8, 2014 at 12:36 PM, Mohit KUMAR DCG <Mohit.KUMAR@...com> wrote:
> Hello Arnd,
>
> Pls find SPEAr1310 pcie patches to be merged through arm-soc tree.
> These patches are rebased on the top of 3-16-rc3.
>
> git://git.kernel.org/pub/scm/linux/kernel/git/vireshk/linux.git
> spear/pcie-support-v8

You actually sent this request before Arnd's reply :).

This is what he asked for:

"Please also include a description of the overall series and the
reasons why we decided
to merge it through arm-soc in the pull request email. Thanks!"

Also this is not how we send pull requests, please see this:
http://git-scm.com/docs/git-request-pull

Let me know if you need some help.

Also, build-bot reported a warning with your patches and I have
fixed it now:

>> WARNING: drivers/built-in.o(.data+0x334): Section mismatch in reference from the variable spear1310_miphy_driver to the function .init.text:spear1310_miphy_probe()

diff --git a/drivers/phy/phy-spear1310-miphy.c
b/drivers/phy/phy-spear1310-miphy.c
index 6136634..dc0b97a 100644
--- a/drivers/phy/phy-spear1310-miphy.c
+++ b/drivers/phy/phy-spear1310-miphy.c
@@ -205,7 +205,7 @@ static struct phy *spear1310_miphy_xlate(struct device *dev,
        return priv->phy;
 }

-static int __init spear1310_miphy_probe(struct platform_device *pdev)
+static int spear1310_miphy_probe(struct platform_device *pdev)
 {
        struct device *dev = &pdev->dev;
        struct spear1310_miphy_priv *priv;
diff --git a/drivers/phy/phy-spear1340-miphy.c
b/drivers/phy/phy-spear1340-miphy.c
index cbaf284..e06e944 100644
--- a/drivers/phy/phy-spear1340-miphy.c
+++ b/drivers/phy/phy-spear1340-miphy.c
@@ -235,7 +235,7 @@ static struct phy *spear1340_miphy_xlate(struct device *dev,
        return priv->phy;
 }

-static int __init spear1340_miphy_probe(struct platform_device *pdev)
+static int spear1340_miphy_probe(struct platform_device *pdev)
 {
        struct device *dev = &pdev->dev;
        struct spear1340_miphy_priv *priv;

Please let me know if I screwed up. Else send pull request from
this branch again.

--
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/