linux-kernel - Re: [alsa-devel] [PATCH v2] ASoC: tda998x: add a codec to the HDMI transmitter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53BBB746.1000201@arm.com>
Date:	Tue, 08 Jul 2014 10:17:58 +0100
From:	Andrew Jackson <Andrew.Jackson@....com>
To:	Jean-Francois Moine <moinejf@...e.fr>,
	Mark Brown <broonie@...nel.org>,
	Russell King - ARM Linux <linux@....linux.org.uk>
CC:	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
	"lgirdwood@...il.com" <lgirdwood@...il.com>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Rob Clark <robdclark@...il.com>,
	Dave Airlie <airlied@...il.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [alsa-devel] [PATCH v2] ASoC: tda998x: add a codec to the HDMI
 transmitter

On 07/04/14 08:17, Jean-Francois Moine wrote:
> This patch adds a CODEC function to the NXP TDA998x HDMI transmitter.
> 
> The CODEC handles both I2S and S/PDIF input and does dynamic input
> switch in the TDA998x I2C driver on start/stop audio streaming.
> 
> Signed-off-by: Jean-Francois Moine <moinejf@...e.fr>
> ---

[snip]

> +++ b/drivers/gpu/drm/i2c/tda998x_codec.c

[snip]

> +static int tda_startup(struct snd_pcm_substream *substream,
> +                       struct snd_soc_dai *dai)
> +{
> +       struct tda998x_priv *priv = snd_soc_codec_get_drvdata(dai->codec);
> +       u8 *eld = priv->eld;
> +       struct snd_pcm_runtime *runtime = substream->runtime;
> +       u8 *sad;
> +       int sad_count;
> +       unsigned eld_ver, mnl, rate_mask;
> +       unsigned max_channels, fmt;
> +       u64 formats;
> +       struct snd_pcm_hw_constraint_list *rate_constraints =
> +                       &priv->rate_constraints;
> +       static const u32 hdmi_rates[] = {
> +               32000, 44100, 48000, 88200, 9600, 176400, 192000
> +       };
> +

Shouldn't this be 96000, not 9600?  Assuming that the table is ordered in terms of increasing frequencies.

    Andrew

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/