linux-kernel - Re: [Intel-gfx] Linux 3.16-rc2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140708125522.GL26405@nuc-i3427.alporthouse.com>
Date:	Tue, 8 Jul 2014 13:55:22 +0100
From:	Chris Wilson <chris@...is-wilson.co.uk>
To:	Jiri Kosina <jkosina@...e.cz>
Cc:	Thomas Meyer <thomas@...3r.de>,
	"intel-gfx@...ts.freedesktop.org" <intel-gfx@...ts.freedesktop.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Pavel Machek <pavel@....cz>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [Intel-gfx] Linux 3.16-rc2

On Tue, Jul 08, 2014 at 02:46:57PM +0200, Jiri Kosina wrote:
> On Tue, 8 Jul 2014, Chris Wilson wrote:
> 
> > > I actually tried to introduce rather large delays between individual 
> > > I915_WRITE() calls in the ring initialization sequence a couple weeks ago 
> > > already, but it resulted in complete machine lockup (which is worse than 
> > > my usual symptoms) during resume. Therefore I probably lack the knowledge 
> > > of internal workings of the HW that would allow me to guess what the 
> > > reasonable timeout value should be.
> > > 
> > > Willing to test any patches.
> > 
> > Are you using the extra patches on bug 76554? If not, try
> 
> Just for debugging.
> 
> > diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c
> > index e18ed05dc0d5..48326f9628d4 100644
> > --- a/drivers/gpu/drm/i915/intel_ringbuffer.c
> > +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
> > @@ -526,6 +526,9 @@ static int init_ring_common(struct intel_engine_cs *ring)
> >                         ((ringbuf->size - PAGE_SIZE) & RING_NR_PAGES)
> >                         | RING_VALID);
> >  
> > +       I915_WRITE_HEAD(ring, 0);
> > +       (void)I915_READ_HEAD(ring);
> > +
> >         /* If the head is still not zero, the ring is dead */
> >         if (wait_for((I915_READ_CTL(ring) & RING_VALID) != 0 &&
> >                      I915_READ_START(ring) == i915_gem_obj_ggtt_offset(obj) &&
> 
> Tried on top of current Linus' tree, and no improvement. ring 
> initialization failure upon resume, and window redrawing hosed.

Which error during ring-init are you hitting?
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/