linux-kernel - Re: [PATCH v2 6/7] regulator: tps65218: Add get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140708133912.GH25811@saruman.home>
Date:	Tue, 8 Jul 2014 08:39:12 -0500
From:	Felipe Balbi <balbi@...com>
To:	Keerthy <j-keerthy@...com>
CC:	<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-omap@...r.kernel.org>, <mark.rutland@....com>,
	<galak@...eaurora.org>, <robh+dt@...nel.org>,
	<linux@....linux.org.uk>, <balbi@...com>, <tony@...mide.com>,
	<kishon@...com>, <broonie@...nel.org>
Subject: Re: [PATCH v2 6/7] regulator: tps65218: Add get_voltage ops for
 dcdc5 and dcdc6

On Tue, Jul 08, 2014 at 03:46:36PM +0530, Keerthy wrote:
> Add get_voltage ops for dcdc5 and dcdc6. Both dcdc5 and 6 are fixed regulators
> and hence return min_uV (or max_uV).
> 
> Signed-off-by: Keerthy <j-keerthy@...com>

Reviewed-by: Felipe Balbi <balbi@...com>

> ---
>  drivers/regulator/tps65218-regulator.c |    9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/regulator/tps65218-regulator.c b/drivers/regulator/tps65218-regulator.c
> index 9effe48..700c652 100644
> --- a/drivers/regulator/tps65218-regulator.c
> +++ b/drivers/regulator/tps65218-regulator.c
> @@ -151,6 +151,14 @@ static int tps65218_pmic_disable(struct regulator_dev *dev)
>  				   dev->desc->enable_mask, TPS65218_PROTECT_L1);
>  }
>  
> +static int tps65218_pmic_dcdc56_get_voltage(struct regulator_dev *dev)
> +{
> +	struct tps65218 *tps = rdev_get_drvdata(dev);
> +	unsigned int rid = rdev_get_id(dev);
> +
> +	return tps->info[rid]->min_uV;
> +}
> +
>  /* Operations permitted on DCDC1, DCDC2 */
>  static struct regulator_ops tps65218_dcdc12_ops = {
>  	.is_enabled		= regulator_is_enabled_regmap,
> @@ -179,6 +187,7 @@ static struct regulator_ops tps65218_dcdc56_pmic_ops = {
>  	.is_enabled		= regulator_is_enabled_regmap,
>  	.enable			= tps65218_pmic_enable,
>  	.disable		= tps65218_pmic_disable,
> +	.get_voltage		= tps65218_pmic_dcdc56_get_voltage,
>  };
>  
>  static const struct regulator_desc regulators[] = {
> -- 
> 1.7.9.5
> 

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)