linux-kernel - Re: [PATCH tip/core/rcu 14/17] rcu: remove CONFIG_PROVE_RCU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140708135600.GG4603@linux.vnet.ibm.com>
Date:	Tue, 8 Jul 2014 06:56:01 -0700
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Paul Bolle <pebolle@...cali.nl>
Cc:	linux-kernel@...r.kernel.org, mingo@...nel.org,
	laijs@...fujitsu.com, dipankar@...ibm.com,
	akpm@...ux-foundation.org, mathieu.desnoyers@...icios.com,
	josh@...htriplett.org, niv@...ibm.com, tglx@...utronix.de,
	peterz@...radead.org, rostedt@...dmis.org, dhowells@...hat.com,
	edumazet@...gle.com, dvhart@...ux.intel.com, fweisbec@...il.com,
	oleg@...hat.com, sbw@....edu, Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH tip/core/rcu 14/17] rcu: remove CONFIG_PROVE_RCU_DELAY

On Tue, Jul 08, 2014 at 10:11:06AM +0200, Paul Bolle wrote:
> Paul,
> 
> On Mon, 2014-07-07 at 15:38 -0700, Paul E. McKenney wrote:
> > The CONFIG_PROVE_RCU_DELAY Kconfig parameter doesn't appear to be very
> > effective at finding race conditions, so this commit removes it.
> > 
> > Signed-off-by: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>
> > Cc: Andi Kleen <ak@...ux.intel.com>
> > ---
> >  kernel/rcu/tree.c                                       | 5 -----
> >  kernel/rcu/update.c                                     | 3 ---
> 
> The commit explanation implies that this patch would also remove the
> entry for PROVE_RCU_DELAY in lib/Kconfig.debug. Is there any reason to
> keep it after this patch?
> 
> >  tools/testing/selftests/rcutorture/configs/rcu/TREE01   | 1 -
> >  tools/testing/selftests/rcutorture/configs/rcu/TREE02   | 1 -
> >  tools/testing/selftests/rcutorture/configs/rcu/TREE02-T | 1 -
> >  tools/testing/selftests/rcutorture/configs/rcu/TREE03   | 1 -
> >  tools/testing/selftests/rcutorture/configs/rcu/TREE04   | 1 -
> >  tools/testing/selftests/rcutorture/configs/rcu/TREE05   | 1 -
> >  tools/testing/selftests/rcutorture/configs/rcu/TREE06   | 1 -
> >  tools/testing/selftests/rcutorture/configs/rcu/TREE07   | 1 -
> >  tools/testing/selftests/rcutorture/configs/rcu/TREE08   | 1 -
> >  tools/testing/selftests/rcutorture/configs/rcu/TREE08-T | 1 -
> >  tools/testing/selftests/rcutorture/configs/rcu/TREE09   | 1 -
> >  13 files changed, 19 deletions(-)
> 
> This doesn't touch a few other references in
> tools/testing/selftests/rcutorture/. I have no idea how these tests
> work, so I assume these references are still needed. Is that correct?

Good catch on both counts, fixed.

							Thanx, Paul

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/