linux-kernel - Re: [PATCH] modules: Fix build error in moduleloader.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140708110801.14fc703b@gandalf.local.home>
Date:	Tue, 8 Jul 2014 11:08:01 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	Fengguang Wu <fengguang.wu@...el.com>
Subject: Re: [PATCH] modules: Fix build error in moduleloader.h

On Tue, 08 Jul 2014 09:10:09 +0930
Rusty Russell <rusty@...tcorp.com.au> wrote:
 
> Subject: modules: Fix build error in moduleloader.h
> 
> Fengguang Wu's build bot detected that if moduleloader.h is included in
> a C file (used by ftrace and kprobes to access module_alloc() when
> available), that it can fail to build if CONFIG_MODULES and
> CONFIG_MODULES_USE_ELF_REL is not defined.
> 
> This is because there's a printk() that dereferences struct module to
> print the name of the module. But as struct module does not exist when
> CONFIG_MODULES is not defined we get this error:
> 
>    include/linux/moduleloader.h: In function 'apply_relocate':
> >> include/linux/moduleloader.h:48:63: error: dereferencing pointer to
> >> incomplete type  
>      printk(KERN_ERR "module %s: REL relocation unsupported\n", me->name);
> 								  ^
> Reported-by: kbuild test robot <fengguang.wu@...el.com>
> Based-on-the-true-story-by: Steven Rostedt <rostedt@...dmis.org>

Confirms-rustys-story-ends-the-same-by: Steven Rostedt <rostedt@...dmis.org>

-- Steve


> Signed-off-by: Rusty Russell <rusty@...tcorp.com.au>
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/