linux-kernel - Re: [PATCH] [media] davinci-vpfe: Fix retcode check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 8 Jul 2014 16:41:30 +0100
From:	Prabhakar Lad <prabhakar.csengg@...il.com>
To:	Andrey Utkin <andrey.krieger.utkin@...il.com>
Cc:	Levente Kurusa <lkurusa@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	OSUOSL Drivers <devel@...verdev.osuosl.org>,
	Linux Media <linux-media@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Mauro Carvalho Chehab <m.chehab@...sung.com>,
	Josh Triplett <josh@...htriplett.org>,
	Archana Kumari <archanakumari959@...il.com>,
	Lisa Nguyen <lisa@...apiadmin.com>
Subject: Re: [PATCH] [media] davinci-vpfe: Fix retcode check

Hi Andrey,

Thanks for the patch!

On Tue, Jul 8, 2014 at 3:58 PM, Andrey Utkin
<andrey.krieger.utkin@...il.com> wrote:
> 2014-07-08 17:32 GMT+03:00 Levente Kurusa <lkurusa@...hat.com>:
>> Hmm, while it is true that get_ipipe_mode returns an int, but
>> the consequent call to regw_ip takes an u32 as its second
>> argument. Did it cause a build warning for you? (Can't really
>> check since I don't have ARM cross compilers close-by)
>> If not, then:
>
> Cannot say for sure would compiler complain.
> I also haven't really checked it, and unfortunately even haven't
> succeeded to make a config that would build that code. But i believe
> that warning is still better than misbehaviour.
>
It wont cause any compile warning.

Applied for v3.17

Thanks,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/