linux-kernel - Re: [PATCH] ipv4: icmp: Fix pMTU handling for rare case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140707.172329.1811708260574978031.davem@davemloft.net>
Date:	Mon, 07 Jul 2014 17:23:29 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	edward.allcutt@...nmarket.com
Cc:	kuznet@....inr.ac.ru, jmorris@...ei.org, yoshfuji@...ux-ipv6.org,
	kaber@...sh.net, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ipv4: icmp: Fix pMTU handling for rare case

From: Edward Allcutt <edward.allcutt@...nmarket.com>
Date: Mon, 30 Jun 2014 16:16:02 +0100

> Some older router implementations still send Fragmentation Needed
> errors with the Next-Hop MTU field set to zero. This is explicitly
> described as an eventuality that hosts must deal with by the
> standard (RFC 1191) since older standards specified that those
> bits must be zero.
> 
> Linux had a generic (for all of IPv4) implementation of the algorithm
> described in the RFC for searching a list of MTU plateaus for a good
> value. Commit 46517008e116 ("ipv4: Kill ip_rt_frag_needed().")
> removed this as part of the changes to remove the routing cache.
> Subsequently any Fragmentation Needed packet with a zero Next-Hop
> MTU has been discarded without being passed to the per-protocol
> handlers or notifying userspace for raw sockets.
> 
> When there is a router which does not implement RFC 1191 on an
> MTU limited path then this results in stalled connections since
> large packets are discarded and the local protocols are not
> notified so they never attempt to lower the pMTU.
> 
> One example I have seen is an OpenBSD router terminating IPSec
> tunnels. It's worth pointing out that this case is distinct from
> the BSD 4.2 bug which incorrectly calculated the Next-Hop MTU
> since the commit in question dismissed that as a valid concern.
> 
> All of the per-protocols handlers implement the simple approach from
> RFC 1191 of immediately falling back to the minimum value. Although
> this is sub-optimal it is vastly preferable to connections hanging
> indefinitely.
> 
> Remove the Next-Hop MTU != 0 check and allow such packets
> to follow the normal path.
> 
> Fixes: 46517008e116 ("ipv4: Kill ip_rt_frag_needed().")
> Signed-off-by: Edward Allcutt <edward.allcutt@...nmarket.com>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/