lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon,  7 Jul 2014 16:58:22 -0700
From:	Greg Kroah-Hartman <>
Cc:	Greg Kroah-Hartman <>,, Rik van Riel <>,
	Naoya Horiguchi <>,
	Sunil Pandey <>,
	Peter Zijlstra <>,
	Andrew Morton <>,
	Johannes Weiner <>,
	"Kirill A. Shutemov" <>,
	Linus Torvalds <>,
	Mel Gorman <>,,,,
	Ingo Molnar <>
Subject: [PATCH 3.14 92/94] mm/numa: Remove BUG_ON() in __handle_mm_fault()

3.14-stable review patch.  If anyone has any objections, please let me know.


From: Rik van Riel <>

commit 107437febd495a50e2cd09c81bbaa84d30e57b07 upstream.

Changing PTEs and PMDs to pte_numa & pmd_numa is done with the
mmap_sem held for reading, which means a pmd can be instantiated
and turned into a numa one while __handle_mm_fault() is examining
the value of old_pmd.

If that happens, __handle_mm_fault() should just return and let
the page fault retry, instead of throwing an oops. This is
handled by the test for pmd_trans_huge(*pmd) below.

Signed-off-by: Rik van Riel <>
Reviewed-by: Naoya Horiguchi <>
Reported-by: Sunil Pandey <>
Signed-off-by: Peter Zijlstra <>
Cc: Andrew Morton <>
Cc: Johannes Weiner <>
Cc: Kirill A. Shutemov <>
Cc: Linus Torvalds <>
Cc: Mel Gorman <>
Signed-off-by: Ingo Molnar <>
Patrick McLean <>
Signed-off-by: Greg Kroah-Hartman <>

 mm/memory.c |    3 ---
 1 file changed, 3 deletions(-)

--- a/mm/memory.c
+++ b/mm/memory.c
@@ -3756,9 +3756,6 @@ static int __handle_mm_fault(struct mm_s
-	/* THP should already have been handled */
-	BUG_ON(pmd_numa(*pmd));
 	 * Use __pte_alloc instead of pte_alloc_map, because we can't
 	 * run pte_offset_map on the pmd, if an huge pmd could

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists