linux-kernel - Re: [PATCH] video: fbdev: xen-fbfront.c: Cleaning up useless assignment of function parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140708150812.GC2863@laptop.dumpdata.com>
Date:	Tue, 8 Jul 2014 11:08:12 -0400
From:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
To:	Stefano Stabellini <stefano.stabellini@...citrix.com>
Cc:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	Tomi Valkeinen <tomi.valkeinen@...com>,
	Jingoo Han <jg1.han@...sung.com>,
	Daniel Vetter <daniel.vetter@...ll.ch>,
	linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] video: fbdev: xen-fbfront.c:  Cleaning up useless
 assignment of function parameter

On Mon, Jul 07, 2014 at 11:20:39AM +0100, Stefano Stabellini wrote:
> On Sun, 6 Jul 2014, Rickard Strandqvist wrote:
> > Remove assignment of function parameter, that has no effect outside the function
> > 
> > This was found using a static code analysis program called cppcheck
> > 
> > Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
> 
> Acked-by: Stefano Stabellini <stefano.stabellini@...citrix.com>

and Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
> 
> 
> >  drivers/video/fbdev/xen-fbfront.c |    1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c
> > index 901014b..e1207a1 100644
> > --- a/drivers/video/fbdev/xen-fbfront.c
> > +++ b/drivers/video/fbdev/xen-fbfront.c
> > @@ -222,7 +222,6 @@ static int xenfb_setcolreg(unsigned regno, unsigned red, unsigned green,
> >  	red = CNVT_TOHW(red, info->var.red.length);
> >  	green = CNVT_TOHW(green, info->var.green.length);
> >  	blue = CNVT_TOHW(blue, info->var.blue.length);
> > -	transp = CNVT_TOHW(transp, info->var.transp.length);
> >  #undef CNVT_TOHW
> >  
> >  	v = (red << info->var.red.offset) |
> > -- 
> > 1.7.10.4
> > 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/