linux-kernel - Re: [PATCH 1/2] phy: Kconfig: Re-organize Exynos USB 2.0 PHY configs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <001701cf9b2b$4e228d60$ea67a820$%han@samsung.com>
Date:	Wed, 09 Jul 2014 13:07:31 +0900
From:	Jingoo Han <jg1.han@...sung.com>
To:	'Sachin Kamat' <spk.linux@...il.com>,
	'Tomasz Figa' <t.figa@...sung.com>
Cc:	'open list' <linux-kernel@...r.kernel.org>,
	'linux-samsung-soc' <linux-samsung-soc@...r.kernel.org>,
	'Kishon Vijay Abraham I' <kishon@...com>,
	'Doug Anderson' <dianders@...omium.org>,
	'Vivek Gautam' <gautam.vivek@...sung.com>,
	'Jingoo Han' <jg1.han@...sung.com>
Subject: Re: [PATCH 1/2] phy: Kconfig: Re-organize Exynos USB 2.0 PHY configs

On Wednesday, July 09, 2014 12:42 PM, Sachin Kamat wrote:
> On Tue, Jul 8, 2014 at 9:15 PM, Tomasz Figa <t.figa@...sung.com> wrote:
> > On 30.06.2014 10:56, Sachin Kamat wrote:
> >> Since the USB 2.0 PHYs are required only with EHCI/OHCI USB drivers,
> >
> > That's not true. They are also required for USB gadget controller
> > supported by the DWC2 gadget driver (formerly s3c-hsotg). Otherwise the
> > change makes sense to me.
> 
> Do you propose I amend just the patch description or also add a dependency on
> USB_DWC2 along with EHCI and OHCI. I do not have anything to test this. Based
> on your input I will re-spin the patch.

I agree with Tomasz Figa's statement. Personally, I think that it would
be good to amend the commit message and add a dependency on USB_DWC2. :-)
Thank you.

Best regards,
Jingoo Han

> 
> --
> Regards,
> Sachin.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/