linux-kernel - Re: [PATCH] x86-64: fix vDSO build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140709163015.96c76a7b0e84632bc006fda0@linux-foundation.org>
Date:	Wed, 9 Jul 2014 16:30:15 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	"Jan Beulich" <JBeulich@...e.com>
Cc:	<mingo@...e.hu>, <tglx@...utronix.de>, <hpa@...or.com>,
	"Andy Lutomirski" <luto@...capital.net>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86-64: fix vDSO build

On Thu, 03 Jul 2014 15:34:38 +0100 "Jan Beulich" <JBeulich@...e.com> wrote:

> Certain ld versions (observed with 2.20.0) put an empty .rela.dyn
> section into shared object files, breaking the assumption on the number
> of sections to be copied to the final output. Simply discard any empty
> SHT_REL and SHT_RELA sections to address this.
> 
> Signed-off-by: Jan Beulich <jbeulich@...e.com>
> Cc: Andy Lutomirski <luto@...capital.net>
> ---
>  arch/x86/vdso/vdso2c.h |    3 +++
>  1 file changed, 3 insertions(+)
> 
> --- 3.16-rc3/arch/x86/vdso/vdso2c.h
> +++ 3.16-rc3-x86-vdso-build/arch/x86/vdso/vdso2c.h
> @@ -93,6 +93,9 @@ static void BITSFUNC(copy_section)(struc
>  	uint64_t flags = GET_LE(&in->sh_flags);
>  
>  	bool copy = flags & SHF_ALLOC &&
> +		(GET_LE(&in->sh_size) ||
> +		 (GET_LE(&in->sh_type) != SHT_RELA &&
> +		  GET_LE(&in->sh_type) != SHT_REL)) &&
>  		strcmp(name, ".altinstructions") &&
>  		strcmp(name, ".altinstr_replacement");

Tested-by: Andrew Morton <akpm@...ux-foundation.org>

(hint)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/