linux-kernel - Re: [PATCH v2 1/4] staging: rtl8192u: Remove useless return statement in r819xU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140709080943.GT25880@mwanda>
Date:	Wed, 9 Jul 2014 11:09:43 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	sanjeev sharma <sanjeevsharmaengg@...il.com>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	peter.senna@...il.com, linux-kernel@...r.kernel.org,
	rmfrfs@...il.com, teobaluta@...il.com,
	Sanjeev Sharma <Sanjeev_Sharma@...tor.com>
Subject: Re: [PATCH v2 1/4] staging: rtl8192u: Remove useless return
 statement in r819xU_phy.c

These patches look ok now.  The only thing is that the changelogs are
a little off.

On Wed, Jul 09, 2014 at 11:34:17AM +0530, sanjeev sharma wrote:
> From: sanjeev sharma <sanjeev_sharma@...tor.com>

Don't use the From header unless you are sending patches on behalf of
someone else.  It's better if you can configure your email client so you
can send the patches from your @mentor.com address.  It would be better
if the names were capitalized.

> 
> This is a patch to the r819xU_phy.c file that remove unneeded return statements in code.

Please line wrap the changelog at 72 characters (the same as email).
Otherwise Greg sometimes fixes them manually...

But the patches themselves are nice now.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/