linux-kernel - Re: [PATCH V4] regulator: DA9211 : new regulator driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140709083837.GL30458@sirena.org.uk>
Date:	Wed, 9 Jul 2014 10:38:37 +0200
From:	Mark Brown <broonie@...nel.org>
To:	James Ban <james.ban.opensource@...semi.com>
Cc:	Liam Girdwood <lgirdwood@...il.com>,
	Support Opensource <support.opensource@...semi.com>,
	LKML <linux-kernel@...r.kernel.org>,
	David Dajun Chen <david.chen@...semi.com>
Subject: Re: [PATCH V4] regulator: DA9211 : new regulator driver

On Wed, Jul 09, 2014 at 05:28:59PM +0900, James Ban wrote:

> How about below code for proper handle of interrupt?

That's fine, or you could have a return value which defaults to IRQ_NONE
and then set it to IRQ_HANDLED when you handle a particular bit - that
is more common since that way if multiple things happen to flag
simultaneously they can be handled in one call to the interrupt handler.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)