linux-kernel - Re: [PATCH 3.2 099/125] mm: fix crashes from mbind() merging vmas

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1404870838.26540.30.camel@deadeye.wl.decadent.org.uk>
Date:	Wed, 09 Jul 2014 02:53:58 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Hugh Dickins <hughd@...gle.com>
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	akpm@...ux-foundation.org,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Minchan Kim <minchan.kim@...il.com>,
	Christoph Lameter <cl@...ux.com>,
	Naoya Horiguchi <n-horiguchi@...jp.nec.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH 3.2 099/125] mm: fix crashes from mbind() merging vmas

On Tue, 2014-07-08 at 14:26 -0700, Hugh Dickins wrote:
> On Tue, 8 Jul 2014, Hugh Dickins wrote:
> > On Tue, 8 Jul 2014, Ben Hutchings wrote:
> > 
> > > 3.2.61-rc1 review patch.  If anyone has any objections, please let me know.
> > > 
> > > ------------------
> > > 
> > > From: Hugh Dickins <hughd@...gle.com>
> > > 
> > > commit d05f0cdcbe6388723f1900c549b4850360545201 upstream.
> > 
> > I don't think that's correct, I can't see a change to the
> > "vma = check_range(" in migrate_to_node() which 3.2 and 3.4 trees have.
> > Does it build (without warning) with CONFIG_NUMA and CONFIG_MIGRATION?
> > I expect this version I sent yesterday for 3.4.98 will be good for 3.2:
> 
> Hah, I now see that 098/125 in your series

Which, for anyone who missed it, was commit 082708072a42, 'mm: revert
0def08e3 ("mm/mempolicy.c: check return code of  check_range")'.

> removes precisely the "vma = "
> I was calling attention to.  So all should be okay and you can ignore me.

Right - of course I'm assuming that the reasoning given for that revert
is valid for 3.2.

Ben.

-- 
Ben Hutchings
All the simple programs have been written, and all the good names taken.

Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)