linux-kernel - Re: [PATCH 0/4] New Qualcomm PMIC pin controller drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1404904380.16296.17.camel@iivanov-dev>
Date:	Wed, 09 Jul 2014 14:13:00 +0300
From:	"Ivan T. Ivanov" <iivanov@...sol.com>
To:	Linus Walleij <linus.walleij@...aro.org>
Cc:	Bjorn Andersson <Bjorn.Andersson@...ymobile.com>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Russell King <linux@....linux.org.uk>,
	Grant Likely <grant.likely@...aro.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>
Subject: Re: [PATCH 0/4] New Qualcomm PMIC pin controller drivers

Hi, 

On Wed, 2014-07-09 at 11:43 +0200, Linus Walleij wrote:
> On Mon, Jul 7, 2014 at 5:11 PM, Ivan T. Ivanov <iivanov@...sol.com> wrote:
> 
> > This set of patches adds pin control drivers for Multi-purpose
> > pin (MPP) and General-purpose pin (GPIO) controllers found
> > in Qualcomm PMIC chips.
> >
> > MPP's are enhanced GPIO's with analog circuits, which support
> > following functions in addition to digital input/output: analog
> > input/output and current sinks.
> >
> > PMIC PM8941 have 8 MPP's and 36 GPIO's. PMIC PM8841 have 4 MPP's.
> >
> > Ivan T. Ivanov (4):
> >   pinctrl: qpnp: Qualcomm PMIC pin controller driver
> >   pinctrl: qcom: Add documentation for pinctrl-qpnp binding
> >   pinctrl: qcom: Add PM8941 and PM8941 pinctrl drivers
> >   ARM: dts: qcom: Add PM8941 and PM8841 pinctrl nodes
> 
> Oh, I just spent some 45 minutes reviewing an 8xxx pinctrl driver from
> Björn Andersson
> that *seems* to be doing exactly the same thing.
> 
> Now I have two drivers from people outside Qualcomm :-)
> 
> Some of my review comments on Björn's driver (like using SI units with the pin
> config) are actually adressed in this patch set. The idea to split in subdrivers
> per-ASIC may be good? I don't really know.
> 
> Can you two guys *PLEASE* join efforts and combine your drivers into one?

Not sure. Björn patches cover older PMIC chips, if not mistaken, mine
cover PMIC's used with APQ8074 and onward [1]. Main difference is
the bus which connects them to SoC, interrupts handling, runtime
pin type detection and register map. 

Regards,
Ivan

[1] pm8019, pm8110, pm8226, pm8841, pm8916, pm8941, pm8994, pma8084, 
    pmd9635, pmd9635, pmi8962, pmi8994.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/