linux-kernel - Re: [PATCH 03/14] cpufreq: Add support for per-policy driver data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKohpo=YQwjbDRec6Sj1JbjL-0GbKmzBUxtRY610bHe0suKt6A@mail.gmail.com>
Date:	Wed, 9 Jul 2014 20:37:41 +0530
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	Santosh Shilimkar <santosh.shilimkar@...com>
Cc:	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Shawn Guo <shawn.guo@...aro.org>, Nishanth Menon <nm@...com>,
	Lists linaro-kernel <linaro-kernel@...ts.linaro.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
	Tomasz Figa <t.figa@...sung.com>,
	Stephen Boyd <sboyd@...eaurora.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Thomas P Abraham <thomas.ab@...sung.com>,
	Arvind Chauhan <arvind.chauhan@....com>,
	Sachin Kamat <spk.linux@...il.com>
Subject: Re: [PATCH 03/14] cpufreq: Add support for per-policy driver data

On 9 July 2014 20:03, Santosh Shilimkar <santosh.shilimkar@...com> wrote:
>> diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h
>> index ec4112d..d4b1108 100644
>> --- a/include/linux/cpufreq.h
>> +++ b/include/linux/cpufreq.h
>> @@ -112,6 +112,9 @@ struct cpufreq_policy {
>>       spinlock_t              transition_lock;
>>       wait_queue_head_t       transition_wait;
>>       struct task_struct      *transition_task; /* Task which is doing the transition */
>> +
>> +     /* For cpufreq driver's internal use */
>> +     void                    *driver_data;
>>  };
>>
> Minor comment for consistency either maintain same commenting style
> for the above structure (description after the variable) or may
> be clean up the comments in another patch.

Adding these to the end of variable makes it take multiple lines as we need
to break after 80 columns. And both the styles are already mixed
in existing file. So, would fix it separately in case I go for it :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/