linux-kernel - Re: gpio-omap: wakeup mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 9 Jul 2014 08:24:42 -0700
From:	Tony Lindgren <tony@...mide.com>
To:	Pascal Huerst <pascal.huerst@...il.com>
Cc:	santosh.shilimkar@...com, khilman@...prootsystems.com,
	linus.walleij@...aro.org, gnurou@...il.com,
	linux-omap@...r.kernel.org, linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org, Daniel Mack <daniel@...que.org>
Subject: Re: gpio-omap: wakeup mask

* Pascal Huerst <pascal.huerst@...il.com> [140709 05:47]:
> On 09.07.2014 12:41, Tony Lindgren wrote:
> 
> > If you just comment out the _gpio_rmw part above do
> > things work as expected?
> 
> Yes. It only wakes up on gpio 6 not on gpio 11 anymore.
> 
> > Then if that works as expected, maybe write only some unused bits
> > into wkup_en register and see if it still wakes to all events while
> > it should not?
> 
> If I use the following testcode, everything works as expected:
> 
> //WARN(true, "WARN: bank->base = %08X\n", bank->base);
> 
> if (likely(!(bank->non_wakeup_gpios & gpio_bit))) {
>   //_gpio_rmw(base, bank->regs->wkup_en, gpio_bit, trigger != 0);
>   writel(0xABC00000, base + bank->regs->wkup_en);
> 
>   bank->context.wake_en = readl_relaxed(bank->base +
>     bank->regs->wkup_en);
>   printk("bank->base = %08X gpio = %i bank->context->wake_en = %08X\n",
>     bank->base, gpio, bank->context.wake_en);
> }

Hmm weird. It sounds like something like the following is happening:

1. The first GPIO bank is always powered, and does not need to set
   wake-up events

2. When setting the GPIO wake-up events it seems that enabling any
   wake-up event for the first (16?) bits wakes up the system

You might want to check this with some spare GPIOs not in the
first bank and see if you need the wake-up events and if enabling
some bits enables more than one GPIO for wake-up events.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/