linux-kernel - Re: [PATCH 1/1] rcu: use true/false instead of 1/0 for a bool type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140709164242.GP4603@linux.vnet.ibm.com>
Date:	Wed, 9 Jul 2014 09:42:42 -0700
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Pranith Kumar <bobby.prani@...il.com>
Cc:	Josh Triplett <josh@...htriplett.org>,
	"open list:READ-COPY UPDATE..." <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] rcu: use true/false instead of 1/0 for a bool type

On Wed, Jul 09, 2014 at 12:08:17AM -0400, Pranith Kumar wrote:
> One more bool type change which I found while reading the code.
> 
> Use true/false instead of 0/1 for a bool type
> 
> Signed-off-by: Pranith Kumar <bobby.prani@...il.com>

Queued for 3.18, thank you!

							Thanx, Paul

> ---
>  kernel/rcu/tree.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
> index 1b70cb6..bc7b6f1 100644
> --- a/kernel/rcu/tree.c
> +++ b/kernel/rcu/tree.c
> @@ -1668,7 +1668,7 @@ static int rcu_gp_fqs(struct rcu_state *rsp, int fqs_state_in)
>  	if (fqs_state == RCU_SAVE_DYNTICK) {
>  		/* Collect dyntick-idle snapshots. */
>  		if (is_sysidle_rcu_state(rsp)) {
> -			isidle = 1;
> +			isidle = true;
>  			maxj = jiffies - ULONG_MAX / 4;
>  		}
>  		force_qs_rnp(rsp, dyntick_save_progress_counter,
> @@ -1677,7 +1677,7 @@ static int rcu_gp_fqs(struct rcu_state *rsp, int fqs_state_in)
>  		fqs_state = RCU_FORCE_QS;
>  	} else {
>  		/* Handle dyntick-idle and offline CPUs. */
> -		isidle = 0;
> +		isidle = false;
>  		force_qs_rnp(rsp, rcu_implicit_dynticks_qs, &isidle, &maxj);
>  	}
>  	/* Clear flag to prevent immediate re-entry. */
> @@ -2449,7 +2449,7 @@ static void force_qs_rnp(struct rcu_state *rsp,
>  		for (; cpu <= rnp->grphi; cpu++, bit <<= 1) {
>  			if ((rnp->qsmask & bit) != 0) {
>  				if ((rnp->qsmaskinit & bit) != 0)
> -					*isidle = 0;
> +					*isidle = false;
>  				if (f(per_cpu_ptr(rsp->rda, cpu), isidle, maxj))
>  					mask |= bit;
>  			}
> -- 
> 1.9.1
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/