linux-kernel - Re: [PATCH 1/1] drivers/input/touchscreen/edt-ft5x06.c: remove unnecessary null test before debugfs_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140709164647.GA10364@core.coreip.homeip.net>
Date:	Wed, 9 Jul 2014 09:46:47 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Fabian Frederick <fabf@...net.be>
Cc:	linux-kernel@...r.kernel.org, Henrik Rydberg <rydberg@...omail.se>,
	linux-input@...r.kernel.org
Subject: Re: [PATCH 1/1] drivers/input/touchscreen/edt-ft5x06.c: remove
 unnecessary null test before debugfs_remove_recursive

On Fri, Jun 27, 2014 at 10:38:32PM +0200, Fabian Frederick wrote:
> Fix checkpatch warning:
> "WARNING: debugfs_remove_recursive(NULL) is safe this check is probably not required"
> 
> Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>
> Cc: Henrik Rydberg <rydberg@...omail.se>
> Cc: linux-input@...r.kernel.org
> Signed-off-by: Fabian Frederick <fabf@...net.be>

Applied, thank you.

> ---
>  drivers/input/touchscreen/edt-ft5x06.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c
> index d4f3399..5a6d50c 100644
> --- a/drivers/input/touchscreen/edt-ft5x06.c
> +++ b/drivers/input/touchscreen/edt-ft5x06.c
> @@ -733,8 +733,7 @@ edt_ft5x06_ts_prepare_debugfs(struct edt_ft5x06_ts_data *tsdata,
>  static void
>  edt_ft5x06_ts_teardown_debugfs(struct edt_ft5x06_ts_data *tsdata)
>  {
> -	if (tsdata->debug_dir)
> -		debugfs_remove_recursive(tsdata->debug_dir);
> +	debugfs_remove_recursive(tsdata->debug_dir);
>  	kfree(tsdata->raw_buffer);
>  }
>  
> -- 
> 1.8.4.5
> 

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/