lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 9 Jul 2014 19:49:35 +0200 From: Sebastian Andrzej Siewior <bigeasy@...utronix.de> To: linux-omap@...r.kernel.org Cc: linux-arm-kernel@...ts.infradead.org, Tony Lindgren <tony@...mide.com>, Felipe Balbi <balbi@...com>, linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org, Sebastian Andrzej Siewior <bigeasy@...utronix.de> Subject: [PATCH 4/6] tty: serial: 8250-core: reorder serial8250_stop_rx() & serial8250_start_tx() With the upcomming rs485 support it is required that serial8250_stop_rx() is called from serial8250_start_tx(). With this reordering there is no need for a forward declaration of the former function. Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de> --- drivers/tty/serial/8250/8250_core.c | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c index 1a91a89..c7c3bf7 100644 --- a/drivers/tty/serial/8250/8250_core.c +++ b/drivers/tty/serial/8250/8250_core.c @@ -1306,6 +1306,21 @@ static void serial8250_stop_tx(struct uart_port *port) pm_runtime_put_autosuspend(port->dev); } +static void serial8250_stop_rx(struct uart_port *port) +{ + struct uart_8250_port *up = + container_of(port, struct uart_8250_port, port); + + pm_runtime_get_sync(port->dev); + + up->ier &= ~UART_IER_RLSI; + up->port.read_status_mask &= ~UART_LSR_DR; + serial_port_out(port, UART_IER, up->ier); + + pm_runtime_mark_last_busy(port->dev); + pm_runtime_put_autosuspend(port->dev); +} + static void serial8250_start_tx(struct uart_port *port) { struct uart_8250_port *up = @@ -1339,21 +1354,6 @@ static void serial8250_start_tx(struct uart_port *port) pm_runtime_put_autosuspend(port->dev); } -static void serial8250_stop_rx(struct uart_port *port) -{ - struct uart_8250_port *up = - container_of(port, struct uart_8250_port, port); - - pm_runtime_get_sync(port->dev); - - up->ier &= ~UART_IER_RLSI; - up->port.read_status_mask &= ~UART_LSR_DR; - serial_port_out(port, UART_IER, up->ier); - - pm_runtime_mark_last_busy(port->dev); - pm_runtime_put_autosuspend(port->dev); -} - static void serial8250_enable_ms(struct uart_port *port) { struct uart_8250_port *up = -- 2.0.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists