linux-kernel - Re: [PATCH] staging: gdm72xx: conditionally compile debug code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140709185142.GA13271@kroah.com>
Date:	Wed, 9 Jul 2014 11:51:42 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Michalis Pappas <mpappas@...tmail.fm>
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: gdm72xx: conditionally compile debug code

On Tue, Jul 01, 2014 at 02:00:15PM +0100, Michalis Pappas wrote:
> Signed-off-by: Michalis Pappas <mpappas@...tmail.fm>
> ---
>  drivers/staging/gdm72xx/gdm_qos.c   | 2 ++
>  drivers/staging/gdm72xx/gdm_sdio.c  | 7 +++++++
>  drivers/staging/gdm72xx/gdm_usb.c   | 7 +++++++
>  drivers/staging/gdm72xx/gdm_wimax.c | 6 ++++++
>  drivers/staging/gdm72xx/gdm_wimax.h | 2 ++
>  5 files changed, 24 insertions(+)
> 
> diff --git a/drivers/staging/gdm72xx/gdm_qos.c b/drivers/staging/gdm72xx/gdm_qos.c
> index b08c8e1..7900981 100644
> --- a/drivers/staging/gdm72xx/gdm_qos.c
> +++ b/drivers/staging/gdm72xx/gdm_qos.c
> @@ -88,7 +88,9 @@ static void free_qos_entry_list(struct list_head *free_list)
>  		total_free++;
>  	}
>  
> +	#if defined(GDM72xx_DEBUG)
>  	pr_debug("%s: total_free_cnt=%d\n", __func__, total_free);
> +	#endif

Ick, no, never put #ifdef in .c code if you can help it.  For stuff like
this, just rely on the dynamic debug core and use the pr_debug and
dev_dbg() calls, like the driver is doing, so all should be fine.

> diff --git a/drivers/staging/gdm72xx/gdm_sdio.c b/drivers/staging/gdm72xx/gdm_sdio.c
> index 9d2de6f..914fd75 100644
> --- a/drivers/staging/gdm72xx/gdm_sdio.c
> +++ b/drivers/staging/gdm72xx/gdm_sdio.c
> @@ -280,9 +280,11 @@ static void send_sdu(struct sdio_func *func, struct tx_cxt *tx)
>  
>  	spin_unlock_irqrestore(&tx->lock, flags);
>  
> +	#if defined(GDM72xx_DEBUG)
>  	print_hex_dump_debug("sdio_send: ", DUMP_PREFIX_NONE, 16, 1,
>  			     tx->sdu_buf + TYPE_A_HEADER_SIZE,
>  			     aggr_len - TYPE_A_HEADER_SIZE, false);
> +	#endif

This should be moved to use dev_dbg(), along with the other calls to
this function in this file.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/