linux-kernel - Re: [PATCH next-20140704]: staging/rtl8821ae/debug.c: sparse warning correction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140709192327.GA4593@kroah.com>
Date:	Wed, 9 Jul 2014 12:23:27 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Sami Laine <laine.j.sami@...il.com>
Cc:	sachin.kamat@...aro.org, devel@...verdev.osuosl.org,
	trivial@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH next-20140704]: staging/rtl8821ae/debug.c: sparse warning
 correction

On Sun, Jul 06, 2014 at 12:05:53PM +0300, Sami Laine wrote:
> From: Sami Laine <laine.j.sami@...il.com>
> 
> Sparse warning correction:
> 
> vers/staging/rtl8821ae/debug.c:80:23: warning: symbol 'proc_topdir' was
> not declared. Should it be static?
> 
> Signed-off-by: Sami Laine <laine.j.sami@...il.com>
> ---
> diff --git a/drivers/staging/rtl8821ae/debug.c b/drivers/staging/rtl8821ae/debug
> index 8aefbf1..e4a19ba 100644
> --- a/drivers/staging/rtl8821ae/debug.c
> +++ b/drivers/staging/rtl8821ae/debug.c
> @@ -77,7 +77,7 @@ void rtl_dbgp_flag_init(struct ieee80211_hw *hw)
>         /*Init Debug flag enable condition */
>  }
>  
> -struct proc_dir_entry *proc_topdir;
> +static struct proc_dir_entry *proc_topdir;
>  static int rtl_proc_get_mac_0(struct seq_file *m, void *v)
>  {
>         struct ieee80211_hw *hw = m->private;

This does not apply properly, and given the lack of testing of your
other patch, I'm loath to try to fix it up by hand myself :(

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/