linux-kernel - Re: [PATCH v7 04/33] net: set name assign type for names assigned using a static template

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53BE544D.7000104@pengutronix.de>
Date:	Thu, 10 Jul 2014 10:52:29 +0200
From:	Marc Kleine-Budde <mkl@...gutronix.de>
To:	Tom Gundersen <teg@...m.no>, netdev@...r.kernel.org
CC:	linux-kernel@...r.kernel.org, David Miller <davem@...emloft.net>,
	David Herrmann <dh.herrmann@...il.com>,
	Kay Sievers <kay@...y.org>
Subject: Re: [PATCH v7 04/33] net: set name assign type for names assigned
 using a static template

On 07/10/2014 10:17 AM, Tom Gundersen wrote:
> This covers the trivial case:
> 
> alloc_netdev(_, "foo%d", NET_NAME_ENUM, _);
> 
> Signed-off-by: Tom Gundersen <teg@...m.no>
> ---
>  drivers/net/can/dev.c                     | 2 +-

> diff --git a/drivers/net/can/dev.c b/drivers/net/can/dev.c
> index 9f91fcb..2441348 100644
> --- a/drivers/net/can/dev.c
> +++ b/drivers/net/can/dev.c
> @@ -565,7 +565,7 @@ struct net_device *alloc_candev(int sizeof_priv, unsigned int echo_skb_max)
>  	else
>  		size = sizeof_priv;
>  
> -	dev = alloc_netdev(size, "can%d", NET_NAME_UNKNOWN, can_setup);
> +	dev = alloc_netdev(size, "can%d", NET_NAME_ENUM, can_setup);
>  	if (!dev)
>  		return NULL;
>  

For can/dev.c:

Acked-by: Marc Kleine-Budde <mkl@...gutronix.de>

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


Download attachment "signature.asc" of type "application/pgp-signature" (243 bytes)