linux-kernel - Re: [PATCH v2 2/2] virtio: rng: ensure reads happen after successful probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 10 Jul 2014 15:23:11 +0530
From:	Amit Shah <amit.shah@...hat.com>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	Jason Cooper <jason@...edaemon.net>, linux-kernel@...r.kernel.org,
	Virtualization List <virtualization@...ts.linux-foundation.org>,
	Rusty Russell <rusty@...tcorp.com.au>, keescook@...omium.org,
	stable@...r.kernel.org
Subject: Re: [PATCH v2 2/2] virtio: rng: ensure reads happen after successful
 probe

On (Thu) 10 Jul 2014 [16:45:14], Herbert Xu wrote:
> On Wed, Jul 09, 2014 at 12:18:36PM -0400, Jason Cooper wrote:
> > On Sat, Jul 05, 2014 at 11:04:53AM +0530, Amit Shah wrote:
> > > The hwrng core asks for random data in the hwrng_register() call itself
> > > from commit d9e7972619.  This doesn't play well with virtio -- the
> > > DRIVER_OK bit is only set by virtio core on a successful probe, and
> > > we're not yet out of our probe routine when this call is made.  This
> > > causes the host to not acknowledge any requests we put in the virtqueue,
> > > and the insmod or kernel boot process just waits for data to arrive from
> > > the host, which never happens.
> > > 
> > > CC: Kees Cook <keescook@...omium.org>
> > > CC: Jason Cooper <jason@...edaemon.net>
> > > CC: Herbert Xu <herbert@...dor.apana.org.au>
> > > CC: <stable@...r.kernel.org> # For v3.15+
> > > Signed-off-by: Amit Shah <amit.shah@...hat.com>
> > > ---
> > >  drivers/char/hw_random/core.c       |  6 ++++++
> > >  drivers/char/hw_random/virtio-rng.c | 10 ++++++++++
> > >  2 files changed, 16 insertions(+)
> > 
> > Yeah, I don't think there's any viable way to get random data out of
> > virtio-rng at probe time...  :-(
> > 
> > Reviewed-by: Jason Cooper <jason@...edaemon.net>
> 
> OK, if there are no more objections I will take these two patches.

Please wait for the v3 -- I like that one better as it doesn't have
the init weirdness that Kees pointed out.  I'm sending that out in a
few mins.

Thanks!

		Amit
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/