linux-kernel - [PATCH] Staging: panel: fixed frivilous else statement warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1404988468-8032-1-git-send-email-me@vincentheuken.com>
Date:	Thu, 10 Jul 2014 03:34:28 -0700
From:	Vincent Heuken <me@...centheuken.com>
To:	willy@...a-x.org, gregkh@...uxfoundation.org,
	armand.bastien@...oste.net, domdevlin@...e.fr,
	monamagarwal123@...il.com, julia.lawall@...6.fr, arnd@...db.de
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	Vincent Heuken <me@...centheuken.com>
Subject: [PATCH] Staging: panel: fixed frivilous else statement warning

Fixed one instance of the following checkpatch.pl warning in
panel.c:
WARNING: else is not generally useful after a break or return

Signed-off-by: Vincent Heuken <me@...centheuken.com>
---
 drivers/staging/panel/panel.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
index 4e92293..6d1a320 100644
--- a/drivers/staging/panel/panel.c
+++ b/drivers/staging/panel/panel.c
@@ -1800,11 +1800,12 @@ static inline int input_state_high(struct logical_input *input)
 				input->high_timer++;
 		}
 		return 1;
-	} else {
-		/* else signal falling down. Let's fall through. */
-		input->state = INPUT_ST_FALLING;
-		input->fall_timer = 0;
 	}
+
+	/* else signal falling down. Let's fall through. */
+	input->state = INPUT_ST_FALLING;
+	input->fall_timer = 0;
+
 	return 0;
 }
 
-- 
2.0.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/