lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 10 Jul 2014 13:12:53 +0200 From: Emil Goode <emilgoode@...il.com> To: Geert Uytterhoeven <geert@...ux-m68k.org> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Mark Brown <broonie@...aro.org>, Olof Johansson <olof@...om.net>, Dongjin Kim <tobetter@...il.com>, Julius Werner <jwerner@...omium.org>, Marek Szyprowski <m.szyprowski@...sung.com>, USB list <linux-usb@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org> Subject: Re: [PATCH] usb: usb5303: make use of uninitialized err variable Hello Greg and Geert, On Thu, Jul 10, 2014 at 09:38:00AM +0200, Geert Uytterhoeven wrote: > Hi Greg, > > On Thu, Jul 10, 2014 at 12:46 AM, Greg Kroah-Hartman > <gregkh@...uxfoundation.org> wrote: > > On Mon, Jun 02, 2014 at 07:45:25PM +0200, Emil Goode wrote: > >> The variable err is not initialized here, this patch uses it > >> to store an eventual error value from devm_clk_get(). > >> > >> Signed-off-by: Emil Goode <emilgoode@...il.com> > >> Acked-by: Geert Uytterhoeven <geert@...ux-m68k.org> > >> --- > >> drivers/usb/misc/usb3503.c | 10 +++++++--- > >> 1 file changed, 7 insertions(+), 3 deletions(-) > > > This patch fails to apply to my tree :( > > You've already applied > commit ec5734c41bee2ee7c938a8f34853d31cada7e67a > Author: Tushar Behera <tushar.b@...sung.com> > Date: Tue Jun 17 16:38:50 2014 +0530 > > usb: misc: usb3503: Update error code in print message > > 'err' is uninitialized, rather print the error code directly. > > which fixes it slightly different. Yes, my patch was sent about two weeks earlier, but of course please pick the one you think is best. Best regards, Emil Goode -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists