linux-kernel - Re: [PATCH v2] mm/vmalloc.c: clean up map_vm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140710043738.GA13532@kroah.com>
Date:	Wed, 9 Jul 2014 21:37:38 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	WANG Chao <chaowang@...hat.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Zhang Yanfei <zhangyanfei@...fujitsu.com>,
	Minchan Kim <minchan@...nel.org>,
	Nitin Gupta <ngupta@...are.org>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Chris Metcalf <cmetcalf@...era.com>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH v2] mm/vmalloc.c: clean up map_vm_area third argument

On Thu, Jul 10, 2014 at 12:26:07PM +0800, WANG Chao wrote:
> Currently map_vm_area() takes (struct page *** pages) as third argument,
> and after mapping, it moves (*pages) to point to (*pages + nr_mappped_pages).
> 
> It looks like this kind of increment is useless to its caller these
> days. The callers don't care about the increments and actually they're
> trying to avoid this by passing another copy to map_vm_area().
> 
> The caller can always guarantee all the pages can be mapped into
> vm_area as specified in first argument and the caller only cares about
> whether map_vm_area() fails or not.
> 
> This patch cleans up the pointer movement in map_vm_area() and updates
> its callers accordingly.
> 
> v2: Fix arch/tile/kernel/module.c::module_alloc().
> 
> Signed-off-by: WANG Chao <chaowang@...hat.com>
> ---
>  arch/tile/kernel/module.c        |  2 +-
>  drivers/lguest/core.c            |  7 ++-----
>  drivers/staging/android/binder.c |  4 +---
>  include/linux/vmalloc.h          |  2 +-
>  mm/vmalloc.c                     | 14 +++++---------
>  mm/zsmalloc.c                    |  2 +-
>  6 files changed, 11 insertions(+), 20 deletions(-)

Staging code:

Acked-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/