linux-kernel - Re: [PATCH] platform/chrome: pstore: fix dmi table to match all chrome systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANLzEksAZEkFa8jGSSzMgnAy6n+JUJXx+xHOhPnHN2Qh+eY4CA@mail.gmail.com>
Date:	Thu, 10 Jul 2014 10:29:48 -0700
From:	Benson Leung <bleung@...omium.org>
To:	Olof Johansson <olof@...om.net>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] platform/chrome: pstore: fix dmi table to match all
 chrome systems

On Thu, Jul 10, 2014 at 10:20 AM, Olof Johansson <olof@...om.net> wrote:
> Turns out that DMI_SYSTEM_VENDOR is actually the native vendor of each
> Chromebook/box. I tested the original patch on a Pixel that -- surprise,
> has Google as vendor. *facepalm*.
>
> The only other data I can think of to probe on is Google_* in the version
> string.  Checking with our firmware team, all systems should have this
> and nothing else than Chrome hardware should have the coreboot + Google_*
> combination to date.
>
> So, we'll switch to this. For future platforms we are going to move to
> using an ACPI device to configure this instead of a DMI table (yay!),
> so longer-term that will sort itself out.
>
> Signed-off-by: Olof Johansson <olof@...om.net>

Reviewed-by: Benson Leung <bleung@...omium.org>


-- 
Benson Leung
Software Engineer, Chrom* OS
bleung@...omium.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/