linux-kernel - Re: [PATCH] tile: Add underscores to defintions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPDOMVjOh1efYMM4UHv9Ag3o0s02PewAQrbKY3FMBKf9ZGBG7Q@mail.gmail.com>
Date:	Thu, 10 Jul 2014 14:50:52 -0400
From:	Nick Krause <xerofoify@...il.com>
To:	Chris Metcalf <cmetcalf@...era.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tile: Add underscores to defintions

On Thu, Jul 10, 2014 at 2:19 PM, Chris Metcalf <cmetcalf@...era.com> wrote:
> On 7/5/2014 12:32 AM, Nicholas Krause wrote:
>>
>> In file drv_xgbe_impl.h I fixed the definitions for Size Small,
>> Size Large, Size Jumbo to have underscores before and after to
>> follow kernel coding style for internel defentions.
>>
>> Signed-off-by: Nicholas Krause <xerofoify@...il.com>
>> ---
>>   arch/tile/include/hv/drv_xgbe_impl.h | 15 +++------------
>
>
> I don't think there is a kernel coding style for internal definitions.
> It's true that double-underscores mean "more raw" in many places, like
> for things like set_bit() vs __set_bit(), but that's not really
> applicable here.  These files are not exported outside of the kernel
> in any case so we don't need any special treatment for them to mark them
> as "internal definitions".
>
> The comment in any case certainly is silly.  It dates back to Jan 2007
> in our internal version control system.  The tilepro hv headers in
> question are largely frozen at this point in our internal "upstream"
> repository where we take these headers from, so it doesn't seem worth
> the effort to try to improve the comments there, nor worth adding skew
> between those headers and the community headers.
>
> --
> Chris Metcalf, Tilera Corp.
> http://www.tilera.com
Chris ,
Would you like me to remove this comment in a patch instead?
Cheers Nick
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/