lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Thu, 10 Jul 2014 13:38:25 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Kees Cook <keescook@...omium.org>
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	"John W. Linville" <linville@...driver.com>
Subject: Re: [PATCH] staging: r8821ae: avoid leaking format string

On Thu, Jul 10, 2014 at 01:16:11PM -0700, Kees Cook wrote:
> This make sure a format string cannot leak into the work queue name nor
> the printk buffer.
> 
> Signed-off-by: Kees Cook <keescook@...omium.org>
> ---
> This is the third time this set of macros has entered the kernel:
> 
> drivers/net/wireless/rtlwifi/btcoexist/halbtcoutsrc.h
> drivers/staging/rtl8192ee/btcoexist/halbtcoutsrc.h
> drivers/staging/rtl8821ae/btcoexist/halbtcoutsrc.h
> 
> Can we extract these macros to some common place and keep them from returning?

I wish.  These are all from the same company.  Each new version of their
hardware consists of a whole dump of a wireless stack.  People are
working on addressing this issue, by writing "real" drivers for the
hardware, and working with the company to not keep doing this.  But odds
are, I'll get a new driver for the next chip from them that does the
same thing :(

thanks for the patch, I'll queue it up.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists