linux-kernel - Re: [PATCH 00/17] Convert TTM to the new fence interface.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53BF0794.6030606@vmware.com>
Date:	Thu, 10 Jul 2014 23:37:24 +0200
From:	Thomas Hellström <thellstrom@...are.com>
To:	Maarten Lankhorst <maarten.lankhorst@...onical.com>,
	airlied@...ux.ie
CC:	nouveau@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
	dri-devel@...ts.freedesktop.org, bskeggs@...hat.com,
	alexander.deucher@....com, christian.koenig@....com
Subject: Re: [PATCH 00/17] Convert TTM to the new fence interface.


On 2014-07-09 14:29, Maarten Lankhorst wrote:
> This series applies on top of the driver-core-next branch of
> git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git
>
> Before converting ttm to the new fence interface I had to fix some
> drivers to require a reservation before poking with fence_obj.
> After flipping the switch RCU becomes available instead, and
> the extra reservations can be dropped again. :-)
>
> I've done at least basic testing on all the drivers I've converted
> at some point, but more testing is definitely welcomed!

I'm currently on vacation for the next couple of weeks, so I can't test 
or review but otherwise

Acked-by: Thomas Hellstrom <thellstrom@...are.com>

> ---
>
> Maarten Lankhorst (17):
>        drm/ttm: add interruptible parameter to ttm_eu_reserve_buffers
>        drm/ttm: kill off some members to ttm_validate_buffer
>        drm/nouveau: add reservation to nouveau_gem_ioctl_cpu_prep
>        drm/nouveau: require reservations for nouveau_fence_sync and nouveau_bo_fence
>        drm/ttm: call ttm_bo_wait while inside a reservation
>        drm/ttm: kill fence_lock
>        drm/nouveau: rework to new fence interface
>        drm/radeon: add timeout argument to radeon_fence_wait_seq
>        drm/radeon: use common fence implementation for fences
>        drm/qxl: rework to new fence interface
>        drm/vmwgfx: get rid of different types of fence_flags entirely
>        drm/vmwgfx: rework to new fence interface
>        drm/ttm: flip the switch, and convert to dma_fence
>        drm/nouveau: use rcu in nouveau_gem_ioctl_cpu_prep
>        drm/radeon: use rcu waits in some ioctls
>        drm/vmwgfx: use rcu in vmw_user_dmabuf_synccpu_grab
>        drm/ttm: use rcu in core ttm
>
>   drivers/gpu/drm/nouveau/core/core/event.c |    4
>   drivers/gpu/drm/nouveau/nouveau_bo.c      |   59 +---
>   drivers/gpu/drm/nouveau/nouveau_display.c |   25 +-
>   drivers/gpu/drm/nouveau/nouveau_fence.c   |  431 +++++++++++++++++++----------
>   drivers/gpu/drm/nouveau/nouveau_fence.h   |   22 +
>   drivers/gpu/drm/nouveau/nouveau_gem.c     |   55 +---
>   drivers/gpu/drm/nouveau/nv04_fence.c      |    4
>   drivers/gpu/drm/nouveau/nv10_fence.c      |    4
>   drivers/gpu/drm/nouveau/nv17_fence.c      |    2
>   drivers/gpu/drm/nouveau/nv50_fence.c      |    2
>   drivers/gpu/drm/nouveau/nv84_fence.c      |   11 -
>   drivers/gpu/drm/qxl/Makefile              |    2
>   drivers/gpu/drm/qxl/qxl_cmd.c             |    7
>   drivers/gpu/drm/qxl/qxl_debugfs.c         |   16 +
>   drivers/gpu/drm/qxl/qxl_drv.h             |   20 -
>   drivers/gpu/drm/qxl/qxl_fence.c           |   91 ------
>   drivers/gpu/drm/qxl/qxl_kms.c             |    1
>   drivers/gpu/drm/qxl/qxl_object.c          |    2
>   drivers/gpu/drm/qxl/qxl_object.h          |    6
>   drivers/gpu/drm/qxl/qxl_release.c         |  172 ++++++++++--
>   drivers/gpu/drm/qxl/qxl_ttm.c             |   93 ------
>   drivers/gpu/drm/radeon/radeon.h           |   15 -
>   drivers/gpu/drm/radeon/radeon_cs.c        |   10 +
>   drivers/gpu/drm/radeon/radeon_device.c    |   60 ++++
>   drivers/gpu/drm/radeon/radeon_display.c   |   21 +
>   drivers/gpu/drm/radeon/radeon_fence.c     |  283 +++++++++++++++----
>   drivers/gpu/drm/radeon/radeon_gem.c       |   19 +
>   drivers/gpu/drm/radeon/radeon_object.c    |    8 -
>   drivers/gpu/drm/radeon/radeon_ttm.c       |   34 --
>   drivers/gpu/drm/radeon/radeon_uvd.c       |   10 -
>   drivers/gpu/drm/radeon/radeon_vm.c        |   16 +
>   drivers/gpu/drm/ttm/ttm_bo.c              |  187 ++++++-------
>   drivers/gpu/drm/ttm/ttm_bo_util.c         |   28 --
>   drivers/gpu/drm/ttm/ttm_bo_vm.c           |    3
>   drivers/gpu/drm/ttm/ttm_execbuf_util.c    |  146 +++-------
>   drivers/gpu/drm/vmwgfx/vmwgfx_buffer.c    |   47 ---
>   drivers/gpu/drm/vmwgfx/vmwgfx_drv.h       |    1
>   drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c   |   24 --
>   drivers/gpu/drm/vmwgfx/vmwgfx_fence.c     |  329 ++++++++++++----------
>   drivers/gpu/drm/vmwgfx/vmwgfx_fence.h     |   35 +-
>   drivers/gpu/drm/vmwgfx/vmwgfx_resource.c  |   43 +--
>   include/drm/ttm/ttm_bo_api.h              |    7
>   include/drm/ttm/ttm_bo_driver.h           |   29 --
>   include/drm/ttm/ttm_execbuf_util.h        |   22 +
>   44 files changed, 1256 insertions(+), 1150 deletions(-)
>   delete mode 100644 drivers/gpu/drm/qxl/qxl_fence.c
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/