linux-kernel - Re: [PATCH 12/16] i2c: i2c-s3c2410: Drop class based scanning to improve bootup time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 11 Jul 2014 11:29:46 +0530
From:	Sachin Kamat <spk.linux@...il.com>
To:	Wolfram Sang <wsa@...-dreams.de>
Cc:	linux-i2c@...r.kernel.org,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Ben Dooks <ben-linux@...ff.org>,
	Kukjin Kim <kgene.kim@...sung.com>,
	linux-samsung-soc <linux-samsung-soc@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 12/16] i2c: i2c-s3c2410: Drop class based scanning to
 improve bootup time

Hi Wolfram,

On Thu, Jul 10, 2014 at 5:16 PM, Wolfram Sang <wsa@...-dreams.de> wrote:
> This driver has been flagged to drop class based instantiation. The removal
> improves boot-up time and is unneeded for embedded controllers. Users have been
> warned to switch for some time now, so we can actually do the removal. Keep the
> DEPRECATED flag, so the core can inform users that the behaviour finally
> changed now. After another transition period, this flag can go, too.
> While we are here, remove the indentation for the array setup because
> such things always break after some time.
>
> Signed-off-by: Wolfram Sang <wsa@...-dreams.de>
> ---
>  drivers/i2c/busses/i2c-s3c2410.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
> index e828a1dba0e5..6252c051525a 100644
> --- a/drivers/i2c/busses/i2c-s3c2410.c
> +++ b/drivers/i2c/busses/i2c-s3c2410.c
> @@ -1128,11 +1128,11 @@ static int s3c24xx_i2c_probe(struct platform_device *pdev)
>                 s3c24xx_i2c_parse_dt(pdev->dev.of_node, i2c);
>
>         strlcpy(i2c->adap.name, "s3c2410-i2c", sizeof(i2c->adap.name));
> -       i2c->adap.owner   = THIS_MODULE;
> -       i2c->adap.algo    = &s3c24xx_i2c_algorithm;
> +       i2c->adap.owner = THIS_MODULE;
> +       i2c->adap.algo = &s3c24xx_i2c_algorithm;
>         i2c->adap.retries = 2;
> -       i2c->adap.class   = I2C_CLASS_HWMON | I2C_CLASS_SPD | I2C_CLASS_DEPRECATED;
> -       i2c->tx_setup     = 50;
> +       i2c->adap.class = I2C_CLASS_DEPRECATED;
> +       i2c->tx_setup = 50;
>
>         init_waitqueue_head(&i2c->wait);
>
> --

Tested on Exynos 5250 boards.
Tested-by: Sachin Kamat <sachin.kamat@...sung.com>

-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/