linux-kernel - Re: [PATCH v2 0/5] kvm, mem-hotplug: Do not pin ept identity pagetable and apic access page.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53BF82F8.5070707@cn.fujitsu.com>
Date:	Fri, 11 Jul 2014 14:23:52 +0800
From:	Tang Chen <tangchen@...fujitsu.com>
To:	<gleb@...nel.org>, <mtosatti@...hat.com>, <nadav.amit@...il.com>
CC:	Tang Chen <tangchen@...fujitsu.com>, <kvm@...r.kernel.org>,
	<laijs@...fujitsu.com>, <isimatu.yasuaki@...fujitsu.com>,
	<guz.fnst@...fujitsu.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 0/5] kvm, mem-hotplug: Do not pin ept identity pagetable
 and apic access page.

hi Gleb, Marcelo, Nadav,

Would you please help to review these patches ?

Thanks. :)

On 07/08/2014 09:01 PM, Tang Chen wrote:
> ept identity pagetable and apic access page in kvm are pinned in memory.
> As a result, they cannot be migrated/hot-removed.
>
> But actually they don't need to be pinned in memory.
>
> [For ept identity page]
> Just do not pin it. When it is migrated, guest will be able to find the
> new page in the next ept violation.
>
> [For apic access page]
> The hpa of apic access page is stored in VMCS APIC_ACCESS_ADDR pointer.
> When apic access page is migrated, we update VMCS APIC_ACCESS_ADDR pointer
> for each vcpu in addition.
>
> Change log v1 ->  v2:
> 1. Add [PATCH 4/5] to remove unnecessary kvm_arch->ept_identity_pagetable.
> 2. In [PATCH 3/5], only introduce KVM_REQ_APIC_PAGE_RELOAD request.
> 3. In [PATCH 3/5], add set_apic_access_page_addr() for svm.
>
>
> Tang Chen (5):
>    kvm: Add gfn_to_page_no_pin() to translate gfn to page without
>      pinning.
>    kvm: Use APIC_DEFAULT_PHYS_BASE macro as the apic access page address.
>    kvm, mem-hotplug: Do not pin ept identity pagetable in memory.
>    kvm: Remove ept_identity_pagetable from struct kvm_arch.
>    kvm, mem-hotplug: Do not pin apic access page in memory.
>
>   arch/x86/include/asm/kvm_host.h |  2 +-
>   arch/x86/kvm/mmu.c              | 11 +++++++++++
>   arch/x86/kvm/svm.c              |  9 ++++++++-
>   arch/x86/kvm/vmx.c              | 40 ++++++++++++++++++++++------------------
>   arch/x86/kvm/x86.c              | 16 ++++++++++++++--
>   include/linux/kvm_host.h        |  3 +++
>   virt/kvm/kvm_main.c             | 29 ++++++++++++++++++++++++++++-
>   7 files changed, 87 insertions(+), 23 deletions(-)
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/