linux-kernel - Re: Interrupt randomness in 3.14.10-rt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1407110923310.4357@nanos>
Date:	Fri, 11 Jul 2014 09:24:33 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Ben Hutchings <ben@...adent.org.uk>
cc:	LKML <linux-kernel@...r.kernel.org>, stable-rt@...r.kernel.org
Subject: Re: Interrupt randomness in 3.14.10-rt

On Fri, 11 Jul 2014, Ben Hutchings wrote:

> I noticed this change between 3.14.3-rt5 and 3.14.10-rt7:
> 
> --- debian/patches/features/all/rt/random-make-it-work-on-rt.patch      (revision 21522)
> +++ debian/patches/features/all/rt/random-make-it-work-on-rt.patch      (working copy)
> [...]
> ---- a/kernel/irq/manage.c
> -+++ b/kernel/irq/manage.c
> -@@ -942,6 +942,12 @@ static int irq_thread(void *data)
> -               if (action_ret == IRQ_HANDLED)
> -                       atomic_inc(&desc->threads_handled);
> - 
> -+#ifdef CONFIG_PREEMPT_RT_FULL
> -+              migrate_disable();
> -+              add_interrupt_randomness(action->irq, 0,
> -+                               desc->random_ip ^ (unsigned long) action);
> -+              migrate_enable();
> -+#endif
> -               wake_threads_waitq(desc);
> -       }
> - 
> 
> (I.e. old patch included these additions, new patch doesn't.)
> 
> Evidently this was made in the announced 3.14.10-rt6, not -rt7.  Was it
> intentional?  Now irq_desc::random_ip is set but never used.

Hmm, how did I lose that one? Thanks for spotting it! I'll pick it up for rt8

     tglx

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/