linux-kernel - Re: [PATCH 1/2 V2] PCI: introduce device assignment interface and refactory related code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <53BFB13E.1060505@citrix.com>
Date:	Fri, 11 Jul 2014 10:41:18 +0100
From:	David Vrabel <david.vrabel@...rix.com>
To:	Ethan Zhao <ethan.zhao@...cle.com>, <bhelgaas@...gle.com>,
	<konrad.wilk@...cle.com>, <boris.ostrovsky@...cle.com>,
	<gleb@...nel.org>, <pbonzini@...hat.com>,
	<jeffrey.t.kirsher@...el.com>, <jesse.brandeburg@...el.com>,
	<bruce.w.allan@...el.com>, <carolyn.wyborny@...el.com>,
	<donald.c.skidmore@...el.com>, <gregory.v.rose@...el.com>,
	<alexander.h.duyck@...el.com>, <john.ronciak@...el.com>,
	<mitch.a.williams@...el.com>, <alex.williamson@...hat.com>
CC:	<linux-pci@...r.kernel.org>, <kvm@...r.kernel.org>,
	<linux.nics@...el.com>, <e1000-devel@...ts.sourceforge.net>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<ethan.kernel@...il.com>, <vaughan.cao@...cle.com>
Subject: Re: [PATCH 1/2 V2] PCI: introduce device assignment interface and
 refactory related code

On 11/07/14 06:52, Ethan Zhao wrote:
> 
> --- a/drivers/xen/xen-pciback/pci_stub.c
> +++ b/drivers/xen/xen-pciback/pci_stub.c
> @@ -133,7 +133,7 @@ static void pcistub_device_release(struct kref *kref)
>  	xen_pcibk_config_free_dyn_fields(dev);
>  	xen_pcibk_config_free_dev(dev);
>  
> -	dev->dev_flags &= ~PCI_DEV_FLAGS_ASSIGNED;
> +	pci_sriov_deassign_device(dev);
>  	pci_dev_put(dev);
>  
>  	kfree(psdev);
> @@ -404,7 +404,7 @@ static int pcistub_init_device(struct pci_dev *dev)
>  	dev_dbg(&dev->dev, "reset device\n");
>  	xen_pcibk_reset_device(dev);
>  
> -	dev->dev_flags |= PCI_DEV_FLAGS_ASSIGNED;
> +	pci_sriov_assign_device(dev);
>  	return 0;

Xen's PCI passthrough works with all PCI devices not just SR-IOV ones,
so the naming of the helpers isn't correct.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/