linux-kernel - Re: [PATCH 0/5] Input - wacom: split out pad data from the stylus input device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANRwn3QsdGOnmuH3=PP=YaX1NpXrZwcB_1ccnTZ_bg2au=KJXg@mail.gmail.com>
Date:	Thu, 10 Jul 2014 18:21:13 -0700
From:	Jason Gerecke <killertofu@...il.com>
To:	Benjamin Tissoires <benjamin.tissoires@...hat.com>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Ping Cheng <pinglinux@...il.com>,
	Linux Input <linux-input@...r.kernel.org>,
	linux-kernel@...r.kernel.org,
	linuxwacom-devel <linuxwacom-devel@...ts.sourceforge.net>
Subject: Re: [PATCH 0/5] Input - wacom: split out pad data from the stylus
 input device

On Mon, Jun 23, 2014 at 1:57 PM, Benjamin Tissoires
<benjamin.tissoires@...hat.com> wrote:
> Hi,
>
> This patch series aims at simplifying the handling of Wacom devices from the user
> space point of view. As mentioned in the commit message from 1/5, the pad data
> are interleaved into the stylus input for some devices, and into the touch input
> for others.
>
> It doesn't makes real sense to interleave pad with stylus because pad data are
> not linked to the absolute position of a stylus (or its presence). It is a
> device by itself which should have its own input node.
>
> It will also help the handling of the old Wacom Graphire 4 which shares its
> BTN_LEFT and BTN_RIGHT in its pad and in the mouse.
>
> Again, it's not a problem right now because the user space is currently dealing
> with it, but for the Wayland libinput implementation, having something clear
> will really help.
>
> This patch series does not break current X11 behavior, the only change from the
> user will be that an input device will appear as "Wacom ... Pad pad".
>
> I tried to test/debug it as extensively as possible, but I do not guarantee any
> mistake :(
>
> Tested on:
> - Bamboo 16FG 4x5
> - Bamboo 2FG
> - BambooFun 4x5
> - Bamboo
> - Cintiq 12WX
> - Cintiq 21UX2
> - Cintiq 21UX
> - Cintiq 22HD
> - Cintiq 22HDT
> - Cintiq 24HD
> - DTU2231
> - Graphire3
> - Intuos3 9x12
> - Intuos4 WL
> - Intuos5 touch M
> - Intuos Pro S
>
> Note: this patch series might requesting to apply the patch for input->phys
> I just sent:
> https://patchwork.kernel.org/patch/4404391/
>
>
> Cheers,
> Benjamin
>
> Benjamin Tissoires (5):
>   Input - wacom: create a separate input device for pads
>   Input - wacom: split out the pad device for Intuos/Cintiq
>   Input - wacom: split out the pad device for Bamboos
>   Input - wacom: split out the pad device for DTUS
>   Input - wacom: split out the pad device for Graphire G4 and MO
>
>  drivers/input/tablet/wacom.h     |   2 +
>  drivers/input/tablet/wacom_sys.c |  63 +++++++-
>  drivers/input/tablet/wacom_wac.c | 328 ++++++++++++++++++++++++---------------
>  drivers/input/tablet/wacom_wac.h |   2 +
>  4 files changed, 259 insertions(+), 136 deletions(-)
>
> --
> 1.9.0
>

These look fine to me as well (aside from the one minor comment):

Reviewed-by: Jason Gerecke <killertofu@...il.com>

Jason
---
Now instead of four in the eights place /
you’ve got three, ‘Cause you added one  /
(That is to say, eight) to the two,     /
But you can’t take seven from three,    /
So you look at the sixty-fours....
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/