linux-kernel - Re: randconfig build error with next-20140710, in sound/soc/rockchip/rockchip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140711124231.GN30458@sirena.org.uk>
Date:	Fri, 11 Jul 2014 13:42:31 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
Cc:	Jianqun <xjq@...k-chips.com>, Jim Davis <jim.epost@...il.com>,
	linux-next <linux-next@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>, lgirdwood@...il.com,
	perex@...ex.cz, tiwai@...e.de, grant.likely@...aro.org,
	robh+dt@...nel.org, devicetree@...r.kernel.org
Subject: Re: randconfig build error with next-20140710, in
 sound/soc/rockchip/rockchip_i2s.c

On Fri, Jul 11, 2014 at 10:32:21AM +1000, Stephen Rothwell wrote:

> Who ever gave you that advice is wrong.  You should always (except in
> very rare circumstances) include every header file that your code
> references things from.  We have over 20 architectures and many, many
> possible configurations in the kernel build system and the fact that a
> file builds for one is not guarantee that it will build for another
> combination if you depend on implicit includes.

Right, I suspect this is coming from the header minimisation efforts :/

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)