linux-kernel - Re: [PATCH V5] regulator: DA9211 : new regulator driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140711130901.GS30458@sirena.org.uk>
Date:	Fri, 11 Jul 2014 14:09:01 +0100
From:	Mark Brown <broonie@...nel.org>
To:	James Ban <james.ban.opensource@...semi.com>
Cc:	Liam Girdwood <lgirdwood@...il.com>,
	Support Opensource <support.opensource@...semi.com>,
	LKML <linux-kernel@...r.kernel.org>,
	David Dajun Chen <david.chen@...semi.com>
Subject: Re: [PATCH V5] regulator: DA9211 : new regulator driver

On Fri, Jul 11, 2014 at 11:30:58AM +0900, James Ban wrote:

> +	if (chip->chip_irq != 0) {
> +		ret = devm_request_threaded_irq(chip->dev, chip->chip_irq, NULL,
> +					da9211_irq_handler,
> +					IRQF_TRIGGER_LOW|IRQF_ONESHOT,
> +					"da9211", chip);
> +		if (ret != 0) {
> +			dev_err(chip->dev, "Failed to request IRQ: %d\n",
> +				chip->chip_irq);
> +			return ret;
> +		}
> +		dev_info(chip->dev, "# IRQ configured [%d]\n", chip->chip_irq);

As previously noted please remove this print, it's not adding anything.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)