linux-kernel - Re: [patch 38/55] fs: lockd: Use ktime_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 11 Jul 2014 10:04:05 -0400
From:	Trond Myklebust <trond.myklebust@...marydata.com>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	John Stultz <john.stultz@...aro.org>,
	Peter Zijlstra <peterz@...radead.org>,
	"J. Bruce Fields" <bfields@...ldses.org>
Subject: Re: [patch 38/55] fs: lockd: Use ktime_get_ns()

On Fri, Jul 11, 2014 at 9:44 AM, Thomas Gleixner <tglx@...utronix.de> wrote:
> Replace the ever recurring:
>         ts = ktime_get_ts();
>         ns = timespec_to_ns(&ts);
> with
>         ns = ktime_get_ns();
>
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> Cc: "J. Bruce Fields" <bfields@...ldses.org>
> Cc: Trond Myklebust <trond.myklebust@...marydata.com>
> ---
>  fs/lockd/mon.c |    4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> Index: tip/fs/lockd/mon.c
> ===================================================================
> --- tip.orig/fs/lockd/mon.c
> +++ tip/fs/lockd/mon.c
> @@ -306,11 +306,9 @@ static struct nsm_handle *nsm_lookup_pri
>  static void nsm_init_private(struct nsm_handle *nsm)
>  {
>         u64 *p = (u64 *)&nsm->sm_priv.data;
> -       struct timespec ts;
>         s64 ns;
>
> -       ktime_get_ts(&ts);
> -       ns = timespec_to_ns(&ts);
> +       ns = ktime_get_ns();
>         put_unaligned(ns, p);
>         put_unaligned((unsigned long)nsm, p + 1);
>  }
>
>

Looks fine to me.

Acked-by: Trond Myklebust <trond.myklebust@...marydata.com>


-- 
Trond Myklebust

Linux NFS client maintainer, PrimaryData

trond.myklebust@...marydata.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/