linux-kernel - Re: [PATCH] bus: ARM CCN PMU driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1405090954.32598.60.camel@hornet>
Date:	Fri, 11 Jul 2014 16:02:34 +0100
From:	Pawel Moll <pawel.moll@....com>
To:	Russell King - ARM Linux <linux@....linux.org.uk>
Cc:	Rob Herring <robh+dt@...nel.org>,
	Mark Rutland <Mark.Rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	"grant.likely@...aro.org" <grant.likely@...aro.org>,
	Arnd Bergmann <arnd@...db.de>,
	Lorenzo Pieralisi <Lorenzo.Pieralisi@....com>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Stephane Eranian <eranian@...gle.com>,
	Jiri Olsa <jolsa@...hat.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...nel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] bus: ARM CCN PMU driver

On Fri, 2014-07-11 at 15:21 +0100, Russell King - ARM Linux wrote:
> On Fri, Jul 11, 2014 at 03:14:16PM +0100, Pawel Moll wrote:
> > diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig
> > index 1f37d98..6ab2a62 100644
> > --- a/drivers/bus/Kconfig
> > +++ b/drivers/bus/Kconfig
> > @@ -4,14 +4,6 @@
> >  
> >  menu "Bus devices"
> >  
> > -config BRCMSTB_GISB_ARB
> > -	bool "Broadcom STB GISB bus arbiter"
> > -	depends on ARM
> > -	help
> > -	  Driver for the Broadcom Set Top Box System-on-a-chip internal bus
> > -	  arbiter. This driver provides timeout and target abort error handling
> > -	  and internal bus master decoding.
> > -
> ...
> > diff --git a/drivers/bus/Makefile b/drivers/bus/Makefile
> > index 6a4ea7e..493b4ff 100644
> > --- a/drivers/bus/Makefile
> > +++ b/drivers/bus/Makefile
> > @@ -2,14 +2,15 @@
> >  # Makefile for the bus drivers.
> >  #
> >  
> > -obj-$(CONFIG_BRCMSTB_GISB_ARB)	+= brcmstb_gisb.o
> 
> I assume that as these exist in the patch, you haven't looked through
> the patch to check what you're actually submitting... 

This is, obviously, my bad and lack of attention after last minute
rebase, for which I apologise.

> how can we be
> sure that the rest of the patch is what you intend to submit?

Of course you can't be sure, unless you are willing to take my word for
it. Maybe the fact that 46% of the added lines contains upper- or
lowercase string "CCN" matching the subject can support my plea.

Pawel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/