linux-kernel - RE: [PATCH 09/83] hsa/radeon: Add code base of hsa driver for AMD's GPUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <D89D60253BB73A4E8C62F9FD18A939CA01031B37@storexdag02.amd.com>
Date:	Fri, 11 Jul 2014 18:02:39 +0000
From:	"Bridgman, John" <John.Bridgman@....com>
To:	Jerome Glisse <j.glisse@...il.com>,
	Oded Gabbay <oded.gabbay@...il.com>
CC:	David Airlie <airlied@...ux.ie>,
	"Deucher, Alexander" <Alexander.Deucher@....com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"Lewycky, Andrew" <Andrew.Lewycky@....com>,
	Joerg Roedel <joro@...tes.org>,
	"Gabbay, Oded" <Oded.Gabbay@....com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	Kishon Vijay Abraham I <kishon@...com>,
	Sandeep Nair <sandeep_n@...com>,
	Kenneth Heitke <kheitke@...eaurora.org>,
	Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
	Santosh Shilimkar <santosh.shilimkar@...com>,
	Andreas Noever <andreas.noever@...il.com>,
	Lucas Stach <l.stach@...gutronix.de>,
	Philipp Zabel <p.zabel@...gutronix.de>
Subject: RE: [PATCH 09/83] hsa/radeon: Add code base of hsa driver for AMD's
 GPUs



>-----Original Message-----
>From: Jerome Glisse [mailto:j.glisse@...il.com]
>Sent: Friday, July 11, 2014 1:04 PM
>To: Oded Gabbay
>Cc: David Airlie; Deucher, Alexander; linux-kernel@...r.kernel.org; dri-
>devel@...ts.freedesktop.org; Bridgman, John; Lewycky, Andrew; Joerg
>Roedel; Gabbay, Oded; Greg Kroah-Hartman; Rafael J. Wysocki; Kishon Vijay
>Abraham I; Sandeep Nair; Kenneth Heitke; Srinivas Pandruvada; Santosh
>Shilimkar; Andreas Noever; Lucas Stach; Philipp Zabel
>Subject: Re: [PATCH 09/83] hsa/radeon: Add code base of hsa driver for
>AMD's GPUs
>
>On Fri, Jul 11, 2014 at 12:50:09AM +0300, Oded Gabbay wrote:
>> This patch adds the code base of the hsa driver for
>> AMD's GPUs.
>>
>> This driver is called kfd.
>>
>> This initial version supports the first HSA chip, Kaveri.
>>
>> This driver is located in a new directory structure under drivers/gpu.
>>
>> Signed-off-by: Oded Gabbay <oded.gabbay@....com>
>
>There is too coding style issues. While we have been lax on the enforcing the
>scripts/checkpatch.pl rules i think there is a limit to that. I am not strict
>on the 80chars per line but others things needs fixing so we stay inline.
>
>Also i am a bit worried about the license, given top comment in each of the
>files i am not sure this is GPL2 compatible. I would need to ask lawyer to
>review that.
>

Hi Jerome,

Which line in the license are you concerned about ? In theory we're using the same license as the initial code pushes for radeon, and I just did a side-by side compare with the license header on cik.c in the radeon tree and confirmed that the two licenses are identical. 

The cik.c header has an additional "Authors:" line which the kfd files do not, but AFAIK that is not part of the license text proper.

JB
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/